Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pytest #32941

Open
5 of 6 tasks
maxime-desroches opened this issue Jul 9, 2024 · 6 comments · May be fixed by commaai/panda#2049
Open
5 of 6 tasks

Switch to pytest #32941

maxime-desroches opened this issue Jul 9, 2024 · 6 comments · May be fixed by commaai/panda#2049
Labels
bounty CI / testing development related to the openpilot development experience good first issue Feasible for new contributers PC Issues related to running openpilot on PC

Comments

@maxime-desroches
Copy link
Contributor

maxime-desroches commented Jul 9, 2024 •
edited
Loading

This is a central issue tracking the switch from unittest to pytest.

The goal:

  • Switch to pytest
  • Make the tests easy to run

How to do it:

  • Convert from unittest to pytest with a tool like https://github.com/dannysepler/pytestify
  • Write a good default config in each pyproject.toml such that all the tests can be run by only invoking pytest

Needs to be done in each of the following repos:

  • cereal
  • panda
  • opendbc
  • rednose
  • teleoprtc
  • msgq
@maxime-desroches maxime-desroches added good first issue Feasible for new contributers CI / testing bounty PC Issues related to running openpilot on PC development related to the openpilot development experience labels Jul 9, 2024
@maxime-desroches maxime-desroches changed the title [$100 bounty] Switch to pytest Switch to pytest Jul 9, 2024
This was referenced Jul 9, 2024
Merged
Merged
Merged
@ranjanmangla1
Copy link

is it still open?

@maxime-desroches
Copy link
Contributor Author

@ranjanmangla1 Yes, only panda is left if you want to do it

@UkuLoskit
Copy link

i'm working on panda still

@adeebshihadeh adeebshihadeh moved this from Open to Locked in openpilot bounties Jul 11, 2024
@adeebshihadeh
Copy link
Contributor

Locked to @UkuLoskit

@sudoevans
Copy link

Seems like the issues wasn't fixed, Did @UkuLoskit make any update?

@Pious1020

This comment was marked as spam.

Sign in to view
@bongbui321 bongbui321 linked a pull request Sep 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty CI / testing development related to the openpilot development experience good first issue Feasible for new contributers PC Issues related to running openpilot on PC
Projects
Improving the openpilot development experience
Status: In Progress
openpilot bounties
Status: Locked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unittest -> pytest bongbui321/panda
6 participants
@UkuLoskit @adeebshihadeh @maxime-desroches @sudoevans @ranjanmangla1 @Pious1020