Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSS2 undershoots brakes when coming to a stop #1510

Open
sshane opened this issue Nov 19, 2024 · 0 comments
Open

TSS2 undershoots brakes when coming to a stop #1510

sshane opened this issue Nov 19, 2024 · 0 comments
Labels
bug car related to opendbc/car/ toyota

Comments

@sshane
Copy link
Contributor

sshane commented Nov 19, 2024

Similar to #1097, but this is for TSS2, specifically when the request heads towards zero just before stopping.

It doesn't seem to happen in the come to stop maneuver, so I think the change in request matters. the PCM sees the request heading to zero before it stops and lets off the brakes too much.

This undershoot isn't explained by any ACCEL_NET signal, nor NEUTRAL_FORCE, so we'll need to do something similar to the Ford creep compensation we recently added.

From e8e25e221b29f66b/00000000--c549da67eb

image

@sshane sshane added bug car related to opendbc/car/ toyota labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car related to opendbc/car/ toyota
Projects
None yet
Development

No branches or pull requests

1 participant