Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal install for GM ASCM cars #1351

Open
adeebshihadeh opened this issue Jun 28, 2024 · 2 comments
Open

Normal install for GM ASCM cars #1351

adeebshihadeh opened this issue Jun 28, 2024 · 2 comments
Labels
car related to opendbc/car/ gm refactor

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jun 28, 2024

Can we make the ASCM GM cars a completely normal install? That means a single harness, and we remove the OBD-II harness and the 3rd party L&P harness.

I haven't looked into this at all yet, so not sure it's possible. If it's not, let's close this.

It's fine to lose functionality, such as longitudinal control. A normal install will get the ASCM cars back on https://comma.ai/vehicles.

In order to claim the bounty:

  • post the harness diagram
  • must work for the currently supported Chevy Volts
  • get a PR merged to move the GM ASCM cars to this new harness
@adeebshihadeh adeebshihadeh added the car related to opendbc/car/ label Aug 9, 2024
@adeebshihadeh adeebshihadeh transferred this issue from commaai/openpilot Oct 5, 2024
@Thinkpad4by3
Copy link

Thinkpad4by3 commented Nov 23, 2024

I have a working port of this running. Harness uses standard car-harness box at the ASCM with a cable running to the front (similar to Nissan Rogue installation). Latest master is running, confirmed working with stock ACC long, resume, set speed, gas override, etc. I will follow up with diagram, route and PR tomorrow. Car is a 2018 Chevy Volt Premier w/ ACC.

@Thinkpad4by3
Copy link

Thinkpad4by3 commented Nov 23, 2024

Here's what I came up with:

Harness just intercepts the PT bus at the ASCM. Everything else is passed through.
Image
Image

I obtained the connectors here, I am not sure of their actual P/N: https://www.amazon.com/RED-WOLF-Replacement-Connector-Compatible/dp/B099MY1WKR/

Changes were needed in Panda due to quirk with one of the message on GM failing to send after the ASCM boots up.
OpenDBC PR: #1524
Panda PR: commaai/panda#2088

Here is a route of it working on my Volt: 20cb801701fc8237/0000002b--160ea66fef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ gm refactor
Projects
Status: Open
Development

No branches or pull requests

2 participants