Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: detect lateral API #1105

Open
sshane opened this issue May 24, 2024 · 3 comments
Open

Hyundai: detect lateral API #1105

sshane opened this issue May 24, 2024 · 3 comments
Labels
car related to opendbc/car/ enhancement hyundai

Comments

@sshane
Copy link
Contributor

sshane commented May 24, 2024

A lot of newer Hyundai vehicles we have yet to merge are blocked on different lateral control behavior, a mostly complete list is here: https://github.com/commaai/openpilot/discussions/30810

We should find a way to detect when the API is different and how. For the cars above, the main two differences we care about are achieving significantly more or less lateral acceleration when applying the same torque.

To prevent fingerprinting on these new vehicles and giving our users a bad experience, our fuzzy fingerprinting function checks that we've seen the camera part number and build/flash date in the FW. This, however, stops a lot of new cars from fingerprinting when the API has not changed, as we don't know if anything has changed when one of these values gets bumped.

For example, the 2024 EV6 is the same as previous models with a new part number: commaai/openpilot#32524 However the 2024 Kia Sorento Hybrid acheives significantly less lateral acceleration (less than half) and the only thing that was bumped was the date in the FW by a few months (which I suspect is either part build date, FW build date, or flash date).

@sshane sshane added enhancement car related to opendbc/car/ hyundai labels May 24, 2024
@estiens
Copy link

estiens commented May 25, 2024

2024 Ioniq 5 (HDA2) seems to have different wiring harness, not sure if different behavior

@sshane
Copy link
Contributor Author

sshane commented May 25, 2024

Ioniq 5 N or Ioniq 5?

@mscbuck
Copy link

mscbuck commented May 28, 2024

2024 Ioniq 5 (HDA2) seems to have different wiring harness, not sure if different behavior

I have used the 2022-2023 I5 Q harness just fine with SunnyPilot on my 24 I5 Limited, but yes, it does fingerprint as a 2022 and not sure if there really are any model differences that would affect the torque/lat control. I think there is a 2024 "PE" version that is slightly different.

@sshane sshane transferred this issue from commaai/openpilot Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ enhancement hyundai
Projects
None yet
Development

No branches or pull requests

3 participants