Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Agg[T] an alias for Seq[T] #3587

Open
lihaoyi opened this issue Sep 21, 2024 · 1 comment
Open

Make Agg[T] an alias for Seq[T] #3587

lihaoyi opened this issue Sep 21, 2024 · 1 comment
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Sep 21, 2024

Agg was a good idea at the time, but 7 years later I don't think the bespoke complexity is paying off. We should move all user facing APIs to Seq and make Agg an alias for backwards source compatibility

This is a bincompat breaking change and will need to go into 0.13.0

@lihaoyi lihaoyi added this to the 0.13.0 milestone Sep 21, 2024
@lefou
Copy link
Member

lefou commented Sep 23, 2024

Agg ensured (silently) that there were no duplicate entries. When removing it, we should also revise other places like T.sources/Task.Sources or ivyDeps whether they should de-duplicate their inputs to avoid extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants