Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all arg-like APIs take os.Shellable instead of Seq[String] #3481

Open
lihaoyi opened this issue Sep 7, 2024 · 0 comments
Open

Make all arg-like APIs take os.Shellable instead of Seq[String] #3481

lihaoyi opened this issue Sep 7, 2024 · 0 comments
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Sep 7, 2024

They mean the same thing, but os.Shellable is much more ergonomic: you can pass in os.Paths, numbers, Seq[String]s, Seq[os.Shellable]s, Options, PathRefs and it all just works.

Might need to do a bit of digging to figure out what APIs need to be updated, but all the runSubprocess APIs are candidates, mainArgs/jvmArgs, etc. This should let us clean up tons of boilerplate .path.toStrings everywhere

Might need to wait till 0.13.0 when we can break bincompat, but may be able to do it earlier with some careful overloading

@lihaoyi lihaoyi added this to the 0.13.0 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant