New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper saluation handling for test send #134

Open

zopyx opened this issue Dec 17, 2018 · 1 comment

Labels

Contributor

zopyx commented Dec 17, 2018

The salutation handling code is broken for test send:

https://github.com/collective/Products.EasyNewsletter/blob/master/Products/EasyNewsletter/content/ENLIssue.py#L378-L389


(Pdb) salutation_mappings
{'ms': {'de': 'Sehr geehrte Damen und Herren,'}, 'mr': {'de': 'Sehr geehrte Damen und Herren,'}}


(Pdb) salutation = salutation_mappings.get('default', '')
(Pdb) salutation
''
(Pdb) salutation.get(self.Language(), '')
*** AttributeError: 'str' object has no attribute 'get'

The text was updated successfully, but these errors were encountered:

Contributor Author

zopyx commented Dec 17, 2018

The same issue is true for the real send operation.

MrTango added the 01 type: bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment