Fix TypeScript error for global.TextDecoder #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
aymene01
force-pushed
the
fix/textdecoder-type-error
branch
from
6e5ab77 to
c74cb80
Compare
|
@aymene01 Thanks for the PR. We're in the process of migrating from jest to vitest. We'll evaluate whether this change is still valid once those changes land. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a TypeScript error in the jest.setup.ts file within the wallet-sdk package. The TextDecoder was previously throwing a type error, which was bypassed with a @ts-expect-error. This has been resolved by casting TextDecoder to the correct global type.
How did you test your changes?
Ran the existing test suite to ensure no new issues were introduced.
Verified that the TypeScript error is no longer present in the jest.setup.ts file after applying the changes.