Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give meaningful error messages when parsing LPs #133

Open
GeorchW opened this issue May 25, 2020 · 4 comments
Open

Give meaningful error messages when parsing LPs #133

GeorchW opened this issue May 25, 2020 · 4 comments

Comments

@GeorchW
Copy link

GeorchW commented May 25, 2020

Currently, parsing errors for LP files result in CoinError exceptions being thrown, without any further information; it does not even give a stack frame or even just a report of the currently executing method. This makes finding out why a specific LP file cannot be parsed take hours instead of seconds (at least if no debugger is attached).

I would suggest to:

  • add more meaningful error messages than CoinError
  • add line and column numbers to indicate where the problem occurred.

(Opening this issue as requested in coin-or/Clp#146.)

@tkralphs
Copy link
Member

Actually, should have said also that this is an issue for CoinUtils, not really Clp. I'm going to transfer it there. We have a lot going on and a small number of developers, though, so can't promise anything.

@tkralphs tkralphs transferred this issue from coin-or/Clp May 25, 2020
@jjhforrest
Copy link
Contributor

jjhforrest commented May 26, 2020 via email

@GeorchW
Copy link
Author

GeorchW commented May 26, 2020

It's definitely better than nothing. I might be able to tell what the problem with my LP file is with this addition.

@dlaehnemann
Copy link

I can only second this. Any extra context information when debugging input would be great. Might have also helped isolating this bug that I found and reported over in issue #144 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants