Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is everything being capitalized? #93

Open
joerez opened this issue Feb 26, 2025 · 0 comments
Open

Why is everything being capitalized? #93

joerez opened this issue Feb 26, 2025 · 0 comments

Comments

@joerez
Copy link

joerez commented Feb 26, 2025

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-ga4/src/ga4.js b/node_modules/react-ga4/src/ga4.js
index cf6a597..c5a3b7f 100644
--- a/node_modules/react-ga4/src/ga4.js
+++ b/node_modules/react-ga4/src/ga4.js
@@ -417,13 +417,13 @@ export class GA4 {
       // Required Fields
       const fieldObject = {
         hitType: "event",
-        eventCategory: format(category),
-        eventAction: format(action),
+        eventCategory: category,
+        eventAction: action,
       };
 
       // Optional Fields
       if (label) {
-        fieldObject.eventLabel = format(label);
+        fieldObject.eventLabel = label;
       }
 
       if (typeof value !== "undefined") {

This issue body was partially generated by patch-package.


Human writing this part:

Not sure why everything was being capitalized but it was making some event tracking tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant