Squashes bugs from Android crash logs

- Fixed bug causing crash on start for some locales where device locale has no supported currency
- Fixed app crash post-import/export operations
- Updated Contributions section of README

Author: codinguser

README.md

@@ -1,45 +1,58 @@
 # Introduction
 
 Gnucash Mobile for Android is companion application for desktop Gnucash designed for Android.
-It allows you to record transactions on-the-go and export them in the OFX format and later import the data into Gnucash for the desktop. You can create multiple accounts for transactions in Gnucash. Double-entry accounting is also supported. 
+It allows you to record transactions on-the-go and export them in the QIF or OFX format and later import the data into Gnucash for the desktop. You can create multiple accounts for transactions in Gnucash. Double-entry accounting is also supported.
 
 The application supports Android 2.2 Froyo (API level 8) and above. 
 
 
 # Installation
 
-There are different ways to get the Gnucash app for Android; through the app store, or building it yourself.
+There are different ways to get the Gnucash app for Android; through the app store, or building it yourself.
 
 
-### App Store
+### App Store
 
 <a href="http://play.google.com/store/apps/details?id=org.gnucash.android">
   <img alt="Android app on Google Play" src="http://developer.android.com/images/brand/en_generic_rgb_wo_60.png" />
-</a>
-
-
-## Building
-
-The build requires [Maven](http://maven.apache.org/download.html)
-v3.0.3+ and the [Android SDK](http://developer.android.com/sdk/index.html)
-to be installed in your development environment. In addition you'll need to set
-the `ANDROID_HOME` environment variable to the location of your SDK:
-
-    export ANDROID_HOME=/home/roberto/tools/android-sdk
-
-After satisfying those requirements, the build is pretty simple:
-
-* Run `mvn clean package` from the `app` directory to build the APK only
-* Run `mvn clean install` from the root directory to build the app and also run
-  the integration tests, this requires a connected Android device or running
-  emulator. (see this [blog post](http://goo.gl/TprMw) for details)
-
-You might find that your device doesn't let you install your build if you
-already have the version from the Android Market installed.  This is standard
-Android security as it it won't let you directly replace an app that's been
-signed with a different key.  Manually uninstall GnuCash from your device and
+</a>
+
+
+## Building
+
+The build requires [Maven](http://maven.apache.org/download.html)
+v3.0.3+ and the [Android SDK](http://developer.android.com/sdk/index.html)
+to be installed in your development environment. In addition you'll need to set
+the `ANDROID_HOME` environment variable to the location of your SDK:
+
+    export ANDROID_HOME=/home/<user>/tools/android-sdk
+
+After satisfying those requirements, the build is pretty simple:
+
+* Run `mvn clean package` from the `app` directory to build the APK only
+* Run `mvn clean install` from the root directory to build the app and also run
+  the integration tests, this requires a connected Android device or running
+  emulator. (see this [blog post](http://goo.gl/TprMw) for details)
+
+You might find that your device doesn't let you install your build if you
+already have the version from the Android Market installed.  This is standard
+Android security as it it won't let you directly replace an app that's been
+signed with a different key.  Manually uninstall GnuCash from your device and
 you will then be able to install your own built version.
 
+## Contributing
+
+There are several ways you could contribute to the development.
+
+One way is providing translations for locales which are not yet available, or improving translations.
+See this [blog post](http://www.codinguser.com/2012/09/gnucash-for-android-beta-2-lost-in-translation/) for some guidelines.
+
+You could as well contribute code, fixing bugs, new features or automated tests.
+Take a look at the [bug tracker](https://github.com/codinguser/gnucash-android/issues?state=open)
+for ideas where to start.
+
+For development, it is recommended to use the IntelliJ IDEA 13+ IDE for development which is available as free
+community edition. Import the project into the IDE from an external (maven) model.The IDE will resolve dependencies automatically.
 
 #Licence
 Gnucash for Android is free software; you can redistribute it and/or 

app/src/org/gnucash/android/app/GnuCashApplication.java

@@ -19,8 +19,12 @@
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
+import android.util.Log;
 import org.gnucash.android.R;
 
+import java.util.Currency;
+import java.util.Locale;
+
 /**
  * An {@link Application} subclass for retrieving static context
  * @author Ngewi Fet <[email protected]>
@@ -64,4 +68,33 @@ public static boolean shouldSaveOpeningBalances(boolean defaultValue){
         SharedPreferences sharedPrefs = PreferenceManager.getDefaultSharedPreferences(context);
         return sharedPrefs.getBoolean(context.getString(R.string.key_save_opening_balances), defaultValue);
     }
+
+    /**
+     * Returns the default currency code for the application. <br/>
+     * What value is actually returned is determined in this order of priority:<ul>
+     *     <li>User currency preference (manually set be user in the app)</li>
+     *     <li>Default currency for the device locale</li>
+     *     <li>United States Dollars</li>
+     * </ul>
+     *
+     * @return Default currency code string for the application
+     */
+    public static String getDefaultCurrency(){
+        Locale locale = Locale.getDefault();
+        //sometimes the locale en_UK is returned which causes a crash with Currency
+        if (locale.getCountry().equals("UK")) {
+            locale = new Locale(locale.getLanguage(), "GB");
+        }
+
+        String currencyCode = "USD"; //start with USD as the default
+        SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
+        try { //there are some strange locales out there
+            currencyCode = Currency.getInstance(locale).getCurrencyCode();
+        } catch (Throwable e) {
+            Log.e(context.getString(R.string.app_name), e.getMessage());
+        } finally {
+            currencyCode = prefs.getString(context.getString(R.string.key_default_currency), currencyCode);
+        }
+        return currencyCode;
+    }
 }

app/src/org/gnucash/android/db/AccountsDbAdapter.java

@@ -624,10 +624,14 @@ public Money getAccountBalance(long accountId){
      */
     public List<Long> getSubAccountIds(long accountId){
         List<Long> subAccounts = new ArrayList<Long>();
+        String accountUID = getAccountUID(accountId);
+        if (accountUID == null)
+            return subAccounts;
+
         Cursor cursor = mDb.query(AccountEntry.TABLE_NAME,
                 new String[]{AccountEntry._ID},
                 AccountEntry.COLUMN_PARENT_ACCOUNT_UID + " = ?",
-                new String[]{getAccountUID(accountId)},
+                new String[]{accountUID},
                 null, null, null);
 
         if (cursor != null){

app/src/org/gnucash/android/export/ExporterTask.java

@@ -172,7 +172,8 @@ protected void onPostExecute(Boolean exportResult) {
             alertFragment.show(fragmentManager, "transactions_delete_confirmation_dialog");
         }
 
-        mProgressDialog.dismiss();
+        if (mProgressDialog != null && mProgressDialog.isShowing())
+            mProgressDialog.dismiss();
 
     }
 

app/src/org/gnucash/android/importer/GncXmlImportTask.java

@@ -63,7 +63,8 @@ protected Boolean doInBackground(InputStream... inputStreams) {
 
     @Override
     protected void onPostExecute(Boolean importSuccess) {
-        progressDialog.dismiss();
+        if (progressDialog != null && progressDialog.isShowing())
+            progressDialog.dismiss();
 
         int message = importSuccess ? R.string.toast_success_importing_accounts : R.string.toast_error_importing_accounts;
         Toast.makeText(context, message, Toast.LENGTH_LONG).show();

app/src/org/gnucash/android/ui/account/AccountFormFragment.java

@@ -422,14 +422,7 @@ private void setParentAccountSelection(long parentAccountId){
 
         for (int pos = 0; pos < mParentAccountCursorAdapter.getCount(); pos++) {
             if (mParentAccountCursorAdapter.getItemId(pos) == parentAccountId){
-                final int position = pos;
-                mParentAccountSpinner.postDelayed(new Runnable() {
-                    @Override
-                    public void run() {
-                        mParentAccountSpinner.setSelection(position);
-                    }
-                }, 100);
-//                mParentAccountSpinner.setSelection(pos, true);
+                mParentAccountSpinner.setSelection(pos, true);
                 break;
             }
         }

app/src/org/gnucash/android/ui/account/AccountsActivity.java

@@ -43,6 +43,7 @@
 import com.actionbarsherlock.view.MenuItem;
 import com.viewpagerindicator.TitlePageIndicator;
 import org.gnucash.android.R;
+import org.gnucash.android.app.GnuCashApplication;
 import org.gnucash.android.importer.GncXmlImportTask;
 import org.gnucash.android.model.Money;
 import org.gnucash.android.ui.util.Refreshable;
@@ -252,24 +253,9 @@ public void onCreate(Bundle savedInstanceState) {
     private void init() {
         PreferenceManager.setDefaultValues(this, R.xml.fragment_transaction_preferences, false);
 
-        Locale locale = Locale.getDefault();
-        //sometimes the locale en_UK is returned which causes a crash with Currency
-        if (locale.getCountry().equals("UK")) {
-            locale = new Locale(locale.getLanguage(), "GB");
-        }
+        Money.DEFAULT_CURRENCY_CODE = GnuCashApplication.getDefaultCurrency();
 
-        String currencyCode;
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(this);
-        try { //there are some strange locales out there
-            currencyCode = prefs.getString(getString(R.string.key_default_currency),
-                    Currency.getInstance(locale).getCurrencyCode());
-        } catch (Exception e) {
-            Log.e(LOG_TAG, e.getMessage());
-            currencyCode = "USD";
-        }
-
-        Money.DEFAULT_CURRENCY_CODE = currencyCode;
-
         boolean firstRun = prefs.getBoolean(getString(R.string.key_first_run), true);
         if (firstRun){
             createDefaultAccounts();

app/src/org/gnucash/android/ui/transaction/TransactionFormFragment.java

@@ -772,6 +772,7 @@ public static BigDecimal parseInputToDecimal(String amountString){
         if (clean.length() == 0) //empty string
                 return BigDecimal.ZERO;
 		//all amounts are input to 2 decimal places, so after removing decimal separator, divide by 100
+        //TODO: Handle currencies with different kinds of decimal places
 		BigDecimal amount = new BigDecimal(clean).setScale(2,
 				RoundingMode.HALF_EVEN).divide(new BigDecimal(100), 2,
 				RoundingMode.HALF_EVEN);

app/src/org/gnucash/android/ui/transaction/TransactionsListFragment.java

@@ -279,7 +279,7 @@ public void finishEditMode(){
 	 */
 	public void setActionModeTitle(){
 		int count = getListView().getCheckedItemIds().length; //mSelectedIds.size();
-		if (count > 0){			
+		if (count > 0 && mActionMode != null){
 			mActionMode.setTitle(getResources().getString(R.string.title_selected, count));
 		}
 	}