Skip to content

Commit 93651db

Browse files
committed
Updates for v1.4.0-beta6 release
Fixed: Split editor showing wrong currency symbol Fixed: Template transactions overriding user-entered amounts
1 parent 945d766 commit 93651db

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

app/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
1919
package="org.gnucash.android"
20-
android:versionCode="34"
20+
android:versionCode="35"
2121
android:versionName="@string/app_version_name" >
2222

2323
<uses-sdk android:minSdkVersion="8" android:targetSdkVersion="16"/>

app/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
1919
<string name="app_name">GnuCash</string>
20-
<string name="app_version_name">1.4.0-beta5</string>
20+
<string name="app_version_name">1.4.0-beta6</string>
2121
<string name="title_add_account">Create Account</string>
2222
<string name="title_edit_account">Edit Account</string>
2323
<string name="info_details">Info</string>

app/src/org/gnucash/android/ui/transaction/TransactionFormFragment.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,14 +292,22 @@ public Cursor runQuery(CharSequence name) {
292292
public void onItemClick(AdapterView<?> adapterView, View view, int position, long id) {
293293
mTransaction = new Transaction(mTransactionsDbAdapter.getTransaction(id), true);
294294
mTransaction.setTime(System.currentTimeMillis());
295+
//we check here because next method will modify it and we want to catch user-modification
296+
boolean amountEntered = mAmountInputFormatter.isInputModified();
295297
initializeViewsWithTransaction();
296298
List<Split> splitList = mTransaction.getSplits();
297299
boolean isSplitPair = splitList.size() == 2 && splitList.get(0).isPairOf(splitList.get(1));
298300
if (isSplitPair){
299301
mSplitsList.clear();
300-
mAmountEditText.setText(splitList.get(0).getAmount().toPlainString());
302+
if (!amountEntered) //if user already entered an amount
303+
mAmountEditText.setText(splitList.get(0).getAmount().toPlainString());
301304
} else {
302-
setAmountEditViewVisible(View.GONE);
305+
if (amountEntered){ //if user entered own amount, clear
306+
mSplitsList.clear();
307+
setAmountEditViewVisible(View.VISIBLE);
308+
} else {
309+
setAmountEditViewVisible(View.GONE);
310+
}
303311
}
304312
mTransaction = null; //we are creating a new transaction after all
305313
}
@@ -377,7 +385,7 @@ private void initalizeViews() {
377385
code = mTransactionsDbAdapter.getCurrencyCode(accountId);
378386
}
379387
Currency accountCurrency = Currency.getInstance(code);
380-
mCurrencyTextView.setText(accountCurrency.getSymbol(Locale.getDefault()));
388+
mCurrencyTextView.setText(accountCurrency.getSymbol());
381389

382390
if (mUseDoubleEntry){
383391
long defaultTransferAccountID = mAccountsDbAdapter.getDefaultTransferAccountID(accountId);

app/src/org/gnucash/android/ui/transaction/dialog/SplitEditorDialogFragment.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,8 @@ public void onClick(View view) {
196196
updateTransferAccountsList(accountsSpinner);
197197
accountsSpinner.setOnItemSelectedListener(new TypeButtonLabelUpdater(splitTypeButton));
198198

199+
Currency accountCurrency = Currency.getInstance(mAccountsDbAdapter.getCurrencyCode(mAccountId));
200+
splitCurrencyTextView.setText(accountCurrency.getSymbol());
199201
splitTypeButton.setAmountFormattingListener(splitAmountEditText, splitCurrencyTextView);
200202
splitTypeButton.setChecked(mBaseAmount.signum() > 0);
201203
splitUidTextView.setText(UUID.randomUUID().toString());

0 commit comments

Comments
 (0)