Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rollbacks in edit history #340

Open
cellio opened this issue Dec 11, 2020 · 0 comments · May be fixed by #1144
Open

Support rollbacks in edit history #340

cellio opened this issue Dec 11, 2020 · 0 comments · May be fixed by #1144
Assignees
Labels
area: frontend Changes to front-end code complexity: average Not particularly hard, not particularly trivial. priority: medium type: change request New feature or request

Comments

@cellio
Copy link
Member

cellio commented Dec 11, 2020

https://meta.codidact.com/questions/279795

If you need to undo an edit, you have to do it by hand. Let's add rollback support to make that easier.

Suggested presentation: in the edit history for a post, if and only if you have the edit ability, show something with each non-current revision that says "roll back to this version". If the user clicks that, prompt for an edit reason (like for other edits) to be appended to the standard notice: "rolled back to version N (version timestamp)".

Notes:

  1. I'm suggesting we gate it by the edit ability to avoid having rollbacks as suggested edits, which seems like it could be confusing to review. If you can't edit you can't roll back, sorry. You can always leave a comment or raise a flag if there's something that needs attention.

  2. The edit history should clearly show that an edit was a rollback no matter what the person does or doesn't type, hence the standard text there (which can be supplemented). I'm suggesting that we include the version number of the edit being rolled back to, for easier history viewing, and the timestamp of that revision, so it'll be more obvious if somebody just rolled a post back by a year or something.

  3. Yeah, that would require revision numbers in the edit history, which we don't have. Can we?

@cellio cellio added area: frontend Changes to front-end code type: change request New feature or request priority: medium complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Dec 11, 2020
@Taeir Taeir self-assigned this Jul 21, 2023
@Taeir Taeir added complexity: average Not particularly hard, not particularly trivial. and removed complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Jul 21, 2023
@Taeir Taeir mentioned this issue Jul 21, 2023
1 task
@Taeir Taeir linked a pull request Jul 31, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Changes to front-end code complexity: average Not particularly hard, not particularly trivial. priority: medium type: change request New feature or request
Projects
None yet
2 participants