Fixes

Author: asmit27rai

pydatastructs/strings/tests/test_trie.py

@@ -55,12 +55,14 @@ def test_Trie():
     assert trie_1.autocomplete("dict") == ["dict", "dicts", "dicts_lists_tuples"]
 
     trie_2 = Trie()
-    trie_2.bulk_insert(["apple", "app", "apricot", "banana"])
+    trie_2.insert("apple")
+    trie_2.insert("app")
+    trie_2.insert("apricot")
+    trie_2.insert("banana")
     assert trie_2.count_words() == 4
 
     trie_2.clear()
     assert trie_2.count_words() == 0
-    assert trie_2.is_empty()
 
     assert trie_2.is_empty()
 
@@ -70,8 +72,10 @@ def test_Trie():
     assert sorted(trie_3.all_words()) == ["hello", "world"]
 
     trie_4 = Trie()
-    trie_4.bulk_insert(["zebra", "dog", "duck", "dove"])
-    print(trie_4.shortest_unique_prefix())
+    trie_4.insert("zebra")
+    trie_4.insert("dog")
+    trie_4.insert("duck")
+    trie_4.insert("dove")
     assert trie_4.shortest_unique_prefix() == {
         "zebra": "z",
         "dog": "dog",

pydatastructs/strings/trie.py

@@ -180,10 +180,13 @@ def strings_with_prefix(self, string: str) -> list:
         """
 
         def _collect(node: TrieNode, prefix: str, strings: list):
-            if node.is_terminal:
-                strings.append(prefix)
-            for child in node._children:
-                _collect(node.get_child(child), prefix + child, strings)
+            stack = [(node, prefix)]
+            while stack:
+                current_node, current_prefix = stack.pop()
+                if current_node.is_terminal:
+                    strings.append(current_prefix)
+                for child in current_node._children:
+                    stack.append((current_node.get_child(child), current_prefix + child))
 
         strings = []
         walk = self.root
@@ -249,27 +252,10 @@ def autocomplete(self, prefix: str) -> list:
         """
         return self.strings_with_prefix(prefix)
 
-    def bulk_insert(self, words: list) -> None:
-        """
-        Inserts multiple words into the trie.
-
-        Parameters
-        ==========
-
-        words: list
-            A list of words to be inserted.
-
-        Returns
-        =======
-
-        None
-        """
-        for word in words:
-            self.insert(word)
-
     def clear(self) -> None:
         """
-        Clears the trie, removing all words.
+        Resets the Trie by replacing the root node with a new empty node.
+        This effectively clears all words from the Trie.
 
         Returns
         =======