You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello and welcome! This folder has been automatically generated by `@atlaskit/build-releases`, a build tool that works with `bolt` to help you release components from a mono-repository. You can find the full documentation for it [here](https://www.npmjs.com/package/@atlaskit/build-releases)
3
+
Hello and welcome! This folder has been automatically generated by
4
+
`@atlaskit/build-releases`, a build tool that works with `bolt` to help you
5
+
release components from a mono-repository. You can find the full documentation
6
+
for it [here](https://www.npmjs.com/package/@atlaskit/build-releases)
4
7
5
-
To help you get started though, here are some things you should know about this folder:
8
+
To help you get started though, here are some things you should know about this
9
+
folder:
6
10
7
11
## Changesets are automatically generated
8
12
9
-
Changesets are generated by the `build-releases changeset` command, though it may have been given a new name within your repository. As long as you are following a changeset release flow, you shouldn't have any problems.
13
+
Changesets are generated by the `build-releases changeset` command, though it
14
+
may have been given a new name within your repository. As long as you are
15
+
following a changeset release flow, you shouldn't have any problems.
10
16
11
17
## Each changeset is its own folder
12
18
13
-
We use hashes by default for these folder names to avoid collisions when generating them, but there's no harm that will come from renaming them.
19
+
We use hashes by default for these folder names to avoid collisions when
20
+
generating them, but there's no harm that will come from renaming them.
14
21
15
22
## Changesets are automatically removed
16
23
17
-
When `build-releases version` or equivalent command is run, all the changeset folders are removed. This is so we only ever use a changeset once. This makes this a very bad place to store any other information.
24
+
When `build-releases version` or equivalent command is run, all the changeset
25
+
folders are removed. This is so we only ever use a changeset once. This makes
26
+
this a very bad place to store any other information.
18
27
19
28
## Changesets come in two parts
20
29
21
30
You should treat these parts quite differently:
22
31
23
-
-`changes.md` is a file you should feel free to edit as much as you want. It will be prepended to your changelog when you next run your version command.
24
-
-`changes.json` is a file that includes information about releases, what should be versioned by the version command. We strongly recommend against editing this directly, as you may make a new changeset that puts your bolt repository into an invalid state.
32
+
-`changes.md` is a file you should feel free to edit as much as you want. It
33
+
will be prepended to your changelog when you next run your version command.
34
+
-`changes.json` is a file that includes information about releases, what should
35
+
be versioned by the version command. We strongly recommend against editing
36
+
this directly, as you may make a new changeset that puts your bolt repository
37
+
into an invalid state.
25
38
26
39
## I want to edit the information in a `changes.json` - how do I do it safely?
27
40
28
-
The best option is to make a new changeset using the changeset command, copy over the `changes.md`, then delete the old changeset.
41
+
The best option is to make a new changeset using the changeset command, copy
42
+
over the `changes.md`, then delete the old changeset.
29
43
30
44
## Can I rename the folder for my changeset?
31
45
32
-
Absolutely! We need unique hashes to make changesets play nicely with git, but changing your folder from our hash to your own name isn't going to cause any problems.
46
+
Absolutely! We need unique hashes to make changesets play nicely with git, but
47
+
changing your folder from our hash to your own name isn't going to cause any
48
+
problems.
33
49
34
50
## Can I manually delete changesets?
35
51
36
-
You can, but you should be aware this will remove the intent to release communicated by the changeset, and should be done with caution.
52
+
You can, but you should be aware this will remove the intent to release
53
+
communicated by the changeset, and should be done with caution.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+49-20Lines changed: 49 additions & 20 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,23 +2,32 @@
2
2
3
3
Thanks for considering contributing!
4
4
5
-
This project has been developed to serve use-cases that I have encountered with uploading files to codesandbox, and definitely doesn't cover all use-cases. I'd be happy though if you find something else you need for you to contribute a pull request. I'll make sure you get a review quickly.
5
+
This project has been developed to serve use-cases that I have encountered with
6
+
uploading files to codesandbox, and definitely doesn't cover all use-cases. I'd
7
+
be happy though if you find something else you need for you to contribute a pull
8
+
request. I'll make sure you get a review quickly.
6
9
7
-
If you're not confident raising a pull request, open an issue, and I can talk to you about the feature/bug fix you're looking for, and hopefully we can work out how to do it.
10
+
If you're not confident raising a pull request, open an issue, and I can talk to
11
+
you about the feature/bug fix you're looking for, and hopefully we can work out
12
+
how to do it.
8
13
9
14
## For issues
10
15
11
-
If you are reporting a bug, an attempt to understand where in our code the bug comes from, or an easy way to reproduce it is greatly appreciated!
16
+
If you are reporting a bug, an attempt to understand where in our code the bug
17
+
comes from, or an easy way to reproduce it is greatly appreciated!
12
18
13
-
If you are requesting a feature, please make sure your use-case for the feature is clearly stated, so it's easy to evaluate.
19
+
If you are requesting a feature, please make sure your use-case for the feature
20
+
is clearly stated, so it's easy to evaluate.
14
21
15
22
## Deving on this project
16
23
17
-
There are a couple of things that are probably good to know(TM) to dev on this project.
24
+
There are a couple of things that are probably good to know(TM) to dev on this
25
+
project.
18
26
19
27
### How do I get up and running?
20
28
21
-
We are using [bolt](https://github.com/boltpkg/bolt) to manage this monorepo. If you haven't worked on a bolt project, the quick get-up-and-running steps are:
29
+
We are using [bolt](https://github.com/boltpkg/bolt) to manage this monorepo. If
30
+
you haven't worked on a bolt project, the quick get-up-and-running steps are:
22
31
23
32
```sh
24
33
yarn global add bolt
@@ -30,17 +39,20 @@ The `bolt` command will install npm packages and link them.
30
39
31
40
### Observing changes
32
41
33
-
If you are trying to observe changes across linked packages, you will need to make sure they are built.
42
+
If you are trying to observe changes across linked packages, you will need to
43
+
make sure they are built.
34
44
35
-
`yarn build` builds all packages.
36
-
`yarn dev:csb` runs the build script for `codesandboxer` and watches it for changes.
37
-
`yarn dev:rcsb` runs the build script for `react-codesandboxer` and watches it for changes.
45
+
`yarn build` builds all packages.`yarn dev:csb` runs the build script for
46
+
`codesandboxer` and watches it for changes.`yarn dev:rcsb` runs the build
47
+
script for `react-codesandboxer` and watches it for changes.
38
48
39
49
The other packages do not need to be built.
40
50
41
51
### Validating changes
42
52
43
-
Currently validation that things work is mostly being done through tests. The most important tests being the ones in `codesandboxer` and `codesandboxer-fs` which use the `/fixtures` directory to validate how they parse and load files.
53
+
Currently validation that things work is mostly being done through tests. The
54
+
most important tests being the ones in `codesandboxer` and `codesandboxer-fs`
55
+
which use the `/fixtures` directory to validate how they parse and load files.
44
56
45
57
## Adding Templates
46
58
@@ -50,27 +62,44 @@ Codesandboxer currently supports:
50
62
- create-react-app-typescript
51
63
- vue-cli
52
64
53
-
It should be easy to add new templates. Here are the places you would need to modify:
65
+
It should be easy to add new templates. Here are the places you would need to
66
+
modify:
54
67
55
-
1. Add a template file to `packages/codesandboxer/templates/`.
56
-
A template should include a main file that imports from `example.js` (or the relevant filetype), as well as any other necessary files to run the sandbox.
57
-
1a. Once you have your template file, export it from `packages/codesandboxer/templates/index.js` added to the object with the name of the sandbox it is for.
58
-
2. If you want a different template to be used for `codesandboxer-fs` add a template to `packages/codesandboxer-fs/templates` in the same way. (we tend to make templates for codesandboxer-fs call out the use of the sandboxer more explicitly, as it may be less clear how to debug it)
68
+
1. Add a template file to `packages/codesandboxer/templates/`. A template should
69
+
include a main file that imports from `example.js` (or the relevant
70
+
filetype), as well as any other necessary files to run the sandbox. 1a. Once
71
+
you have your template file, export it from
72
+
`packages/codesandboxer/templates/index.js` added to the object with the name
73
+
of the sandbox it is for.
74
+
2. If you want a different template to be used for `codesandboxer-fs` add a
75
+
template to `packages/codesandboxer-fs/templates` in the same way. (we tend
76
+
to make templates for codesandboxer-fs call out the use of the sandboxer more
77
+
explicitly, as it may be less clear how to debug it)
59
78
60
79
## For Pull Requests
61
80
62
81
### Code Standards
63
82
64
-
We're using flow to help keep our code neat. If you could add types to your code, that would be 😎. Code that adds tests for its use-cases is also great.
83
+
We're using flow to help keep our code neat. If you could add types to your
84
+
code, that would be 😎. Code that adds tests for its use-cases is also great.
65
85
66
86
### Documentation
67
87
68
-
If you add anything to the API, please update the documentation as well. (we also accept docs PRs if you see a way to improve our documentation)
88
+
If you add anything to the API, please update the documentation as well. (we
89
+
also accept docs PRs if you see a way to improve our documentation)
69
90
70
91
### Monitoring changes
71
92
72
-
We are using [build-releases](https://www.npmjs.com/package/@atlaskit/build-releases) to add intents to change, so we can make sure our packages are released at the right semantic version. The simple answer is run `yarn changeset` and answer the questions. If you're not certain about semantic versioning, I would recommend checking out [this documentation](https://docs.npmjs.com/about-semantic-versioning).
93
+
We are using
94
+
[build-releases](https://www.npmjs.com/package/@atlaskit/build-releases) to add
95
+
intents to change, so we can make sure our packages are released at the right
96
+
semantic version. The simple answer is run `yarn changeset` and answer the
97
+
questions. If you're not certain about semantic versioning, I would recommend
I'm currently working on a code of conduct, but until that's ready, I wanted to make sure that everyone felt welcome here. If you are looking to contribute, please make sure you are respectful to anyone participating on this project.
103
+
I'm currently working on a code of conduct, but until that's ready, I wanted to
104
+
make sure that everyone felt welcome here. If you are looking to contribute,
105
+
please make sure you are respectful to anyone participating on this project.
0 commit comments