fix build

Signed-off-by: shmck <[email protected]>

Author: ShMcK

Diff for: src/create.ts

@@ -17,9 +17,9 @@ async function create(args: string[]): Promise<void> {
   // dir - default .
   const dir = !args.length || args[0].match(/^-/) ? "." : args[0];
   // lang - default js
-  const lang = getArg(args, { name: "lang", alias: "l" }) || "js";
+  const lang: string = getArg(args, { name: "lang", alias: "l" }) || "js";
   // testRunner - default mocha
-  const testRunner =
+  const testRunner: string =
     getArg(args, { name: "testRunner", alias: "t" }) || "mocha";
 
   // validate lang

Diff for: src/utils/args.ts

@@ -1,27 +1,22 @@
 type ArgValueParams = {
   name: string;
   alias?: string;
-  type?: "string" | "bool" | "number";
 };
 
-function checkValue<T>(
-  args: string[],
-  string: string,
-  isBool: boolean
-): string | null {
+function checkValue<T>(args: string[], string: string): string | null {
   const nameIndex = args.indexOf(string);
   if (nameIndex >= 0) {
     const nextArg = args[nameIndex + 1];
 
     if (nextArg !== undefined) {
       const nextIsCommand = !!nextArg.match(/^\-/);
       if (nextIsCommand) {
-        return isBool ? "true" : null;
+        return null;
       }
       return nextArg;
     } else {
       // no secondary set value
-      return isBool ? "true" : null;
+      return null;
     }
   }
   return null;
@@ -30,35 +25,17 @@ function checkValue<T>(
 export function getArg<T>(
   args: string[],
   options: ArgValueParams
-): string | boolean | number | null {
+): string | null {
   let stringValue: null | string = null;
-  const isBool = options.type === "bool";
 
   if (options.alias) {
     const aliasString = `-${options.alias}`;
-    stringValue = checkValue(args, aliasString, isBool);
+    stringValue = checkValue(args, aliasString);
   }
   if (!stringValue) {
     const nameString = `--${options.name}`;
-    stringValue = checkValue(args, nameString, isBool);
-  }
-
-  if (stringValue === null) {
-    return null;
-  }
-
-  if (!options.type) {
-    options.type = "string";
+    stringValue = checkValue(args, nameString);
   }
 
-  // coerce type
-  switch (options.type) {
-    case "bool":
-      return (stringValue || "").toLowerCase() !== "false";
-    case "number":
-      return Number(stringValue);
-    case "string":
-    default:
-      return stringValue;
-  }
+  return stringValue;
 }

Diff for: src/validate.ts

@@ -22,12 +22,8 @@ async function validate(args: string[]) {
 
   // -y --yaml - default coderoad-config.yml
   const options: Options = {
-    // @ts-ignore
-    yaml:
-      getArg(args, { name: "yaml", alias: "y", type: "string" }) ||
-      "coderoad.yaml",
-    // @ts-ignore
-    clean: getArg(args, { name: "clean", alias: "c", type: "bool" }),
+    yaml: getArg(args, { name: "yaml", alias: "y" }) || "coderoad.yaml",
+    clean: getArg(args, { name: "clean", alias: "c" }) !== "false",
   };
 
   const _yaml: string = await fs.readFile(

Diff for: tests/args.test.ts

@@ -26,44 +26,39 @@ describe("args", () => {
     const result = getArg(args, {
       name: "someBool",
       alias: "sb",
-      type: "bool",
     });
-    expect(result).toBe(true);
+    expect(result).toBe("true");
   });
   it("should convert bool string to false", () => {
     const args = ["--someBool", "false"];
     const result = getArg(args, {
       name: "someBool",
       alias: "sb",
-      type: "bool",
     });
-    expect(result).toBe(false);
+    expect(result).toBe("false");
   });
   it("should default value to true if no next value", () => {
     const args = ["--someBool"];
     const result = getArg(args, {
       name: "someBool",
       alias: "sb",
-      type: "bool",
     });
-    expect(result).toBe(true);
+    expect(result).toBe(null);
   });
   it("should default value to true if next value is --name", () => {
     const args = ["--someBool", "--someOtherBool"];
     const result = getArg(args, {
       name: "someBool",
       alias: "sb",
-      type: "bool",
     });
-    expect(result).toBe(true);
+    expect(result).toBe(null);
   });
   it("should default value to true if next value is -alias", () => {
     const args = ["--someBool", "-a"];
     const result = getArg(args, {
       name: "someBool",
       alias: "sb",
-      type: "bool",
     });
-    expect(result).toBe(true);
+    expect(result).toBe(null);
   });
 });