Skip to content

Commit 4edcada

Browse files
committed
Disable safari compression compatability layer
Closes #218
1 parent 7157c05 commit 4edcada

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

accept.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM
231231
switch ext.name {
232232
case "permessage-deflate":
233233
return acceptDeflate(w, ext, mode)
234-
case "x-webkit-deflate-frame":
235-
return acceptWebkitDeflate(w, ext, mode)
234+
// Disabled for now, see https://github.com/nhooyr/websocket/issues/218
235+
// case "x-webkit-deflate-frame":
236+
// return acceptWebkitDeflate(w, ext, mode)
236237
}
237238
}
238239
return nil, nil

compress.go

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ package websocket
77
// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
88
// It will work the same in every way except that we cannot signal to the peer we
99
// want to use no context takeover on our side, we can only signal that they should.
10+
// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
1011
type CompressionMode int
1112

1213
const (

0 commit comments

Comments
 (0)