Bug: When using AppProxy in Azure, headers are not passed

[bjornrobertsson]

Similar to : #76 but different source.

This is for an Issue a customer raised in Coder directly: coder/coder#17687, after debugging this affects the VS Code extension and using coder cli has different behaviour.

It seems that the Coder Extension misses to pass the --header-command to the CLI while coder cli on it's own will work.

Issue:
I can not start a stopped workspace from a local VSCode instance when Coder is behind a Azure AppProxy (using --header)

Expected behaviour:
Workspace should start

Actual behaviour:
Failed to open workspace

"--global config
...
coder-config-xyz exited with code 1: Encountered an error running "coder start", see "coder start --help" for more information
error: invalid character '<' looking for beginning of value"

Steps to Reproduce
Wait until a workspace is stopped in local VSCode
Reload Window while network was down (has nothing to do with the issue)
When VSCode asks to start the stopped workspace say yes

Coder: 2.20.2
OS: Linux

[MrPeacockNLB]

@code-asher the header command is configured properly.

[matifali]

HI @MrPeacockNLB
Have you correctly configured this in VSCode settings too? vscode://settings/coder.headerCommand

[MrPeacockNLB]

yes of course sir!

Otherwise I would not be able to get the information that the workspace has status "stop". If we do not configure the header command then we have no access to the coder API.

[MrPeacockNLB]

All other functions from the extension seems to work properly.

[matifali]

@MrPeacockNLB, is this a regression that used to work before? Or you recently discovered this while starting to use an APPProxy that requires the headers.

[code-asher]

I think this is probably a regression. We used to make API calls to start the workspace and we switched to using the CLI to start workspaces instead.

For API calls we have a single place where we attach headers (and anything else we need), but this CLI execution was copied from another invocation and it seems parts were missed (including the header command). We should probably have one place where we generate the invocation so everything necessary is attached no matter where or when we exec the CLI.

Edit: I said it was copied from another invocation but that invocation was the proxy command, so they cannot be as easily shared as I was thinking. Maybe we could have a function that returns the common flags though.

[MrPeacockNLB]

I'm not sure if it is regression. I'm not sure if I have had tested this ever before.

[f0ssel]

Related to #500