Fix setting the default flags

Author: EhabY

src/cliConfig.ts

@@ -24,5 +24,6 @@ export function getGlobalFlags(
  * Returns SSH flags for the `coder ssh` command from user configuration.
  */
 export function getSshFlags(configs: WorkspaceConfiguration): string[] {
-	return configs.get<string[]>("coder.sshFlags") || [];
+	// Make sure to match this default with the one in the package.json
+	return configs.get<string[]>("coder.sshFlags", ["--disable-autostart"]);
 }

src/remote/remote.ts

@@ -596,7 +596,7 @@ export class Remote {
 		if (useWildcardSSH) {
 			// User SSH flags are included first; internally-managed flags
 			// are appended last so they take precedence.
-			const userSSHFlags = getSshFlags(vscodeConfig);
+			const userSshFlags = getSshFlags(vscodeConfig);
 			// Make sure to update the `coder.sshFlags` description if we add more internal flags here!
 			const internalFlags = [
 				"--stdio",
@@ -609,7 +609,7 @@ export class Remote {
 				"%h",
 			];
 
-			const allFlags = [...userSSHFlags, ...internalFlags];
+			const allFlags = [...userSshFlags, ...internalFlags];
 			return `${escapedBinaryPath} ${globalConfig.join(" ")} ssh ${allFlags.join(" ")}`;
 		} else {
 			const networkInfoDir = escapeCommandArg(

test/unit/cliConfig.test.ts

@@ -83,12 +83,12 @@ describe("cliConfig", () => {
 	});
 
 	describe("getSshFlags", () => {
-		it("returns empty array when no SSH flags configured", () => {
+		it("returns default flags when no SSH flags configured", () => {
 			const config = {
-				get: () => undefined,
+				get: (_key: string, defaultValue: unknown) => defaultValue,
 			} as unknown as WorkspaceConfiguration;
 
-			expect(getSshFlags(config)).toStrictEqual([]);
+			expect(getSshFlags(config)).toStrictEqual(["--disable-autostart"]);
 		});
 
 		it("returns SSH flags from config", () => {