Skip to content

Commit 8974e8b

Browse files
committed
fix: resolve lint warnings
1 parent 854ca01 commit 8974e8b

File tree

5 files changed

+27
-23
lines changed

5 files changed

+27
-23
lines changed

src/extension.ts

+14-14
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ import { makeCoderSdk, needToken } from "./api"
77
import { errToStr } from "./api-helper"
88
import { Commands } from "./commands"
99
import { CertificateError, getErrorDetail } from "./error"
10+
import { getMemoryLogger } from "./memoryLogger"
1011
import { Remote } from "./remote"
1112
import { Storage } from "./storage"
1213
import { toSafeHost } from "./util"
1314
import { WorkspaceQuery, WorkspaceProvider } from "./workspacesProvider"
14-
import { getMemoryLogger } from "./memoryLogger"
1515

1616
export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
1717
// Initialize the memory logger right when the extension starts.
18-
const logger = getMemoryLogger();
18+
const logger = getMemoryLogger()
1919
await logger.initLogFile(ctx.globalStorageUri.fsPath)
2020

2121
// Log initial memory usage and activation
@@ -26,7 +26,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
2626
ctx.subscriptions.push({ dispose: () => logger.dispose() })
2727

2828
// Log extension mode
29-
logger.info(`Extension mode: ${extensionModeToString(ctx.extensionMode)}`);
29+
logger.info(`Extension mode: ${extensionModeToString(ctx.extensionMode)}`)
3030

3131
// The Remote SSH extension's proposed APIs are used to override the SSH host
3232
// name in VS Code itself. It's visually unappealing having a lengthy name!
@@ -44,9 +44,9 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
4444
vscode.window.showErrorMessage("Remote SSH extension not found, cannot activate Coder extension")
4545
throw new Error("Remote SSH extension not found")
4646
}
47-
48-
logger.info(`Found Remote SSH extension: ${remoteSSHExtension.id}`);
49-
47+
48+
logger.info(`Found Remote SSH extension: ${remoteSSHExtension.id}`)
49+
5050
// eslint-disable-next-line @typescript-eslint/no-explicit-any
5151
const vscodeProposed: typeof vscode = (module as any)._load(
5252
"vscode",
@@ -251,19 +251,19 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
251251
function extensionModeToString(mode: vscode.ExtensionMode): string {
252252
switch (mode) {
253253
case vscode.ExtensionMode.Development:
254-
return "Development";
254+
return "Development"
255255
case vscode.ExtensionMode.Production:
256-
return "Production";
256+
return "Production"
257257
case vscode.ExtensionMode.Test:
258-
return "Test";
258+
return "Test"
259259
default:
260-
return `Unknown (${mode})`;
260+
return `Unknown (${mode})`
261261
}
262262
}
263263

264264
// Add deactivation handler to log memory usage on extension shutdown
265265
export function deactivate(): void {
266-
const logger = getMemoryLogger();
267-
logger.info("Coder extension deactivating");
268-
logger.logMemoryUsage("EXTENSION_DEACTIVATE");
269-
}
266+
const logger = getMemoryLogger()
267+
logger.info("Coder extension deactivating")
268+
logger.logMemoryUsage("EXTENSION_DEACTIVATE")
269+
}

src/inbox.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { ProxyAgent } from "proxy-agent"
44
import * as vscode from "vscode"
55
import { WebSocket } from "ws"
66
import { errToStr } from "./api-helper"
7-
import { type Storage } from "./storage"
87
import { getMemoryLogger } from "./memoryLogger"
8+
import { type Storage } from "./storage"
99

1010
// These are the template IDs of our notifications.
1111
// Maybe in the future we should avoid hardcoding

src/memoryLogger.ts

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import * as vscode from "vscode"
1+
import * as fs from "fs/promises"
22
import * as os from "os"
33
import * as path from "path"
4-
import * as fs from "fs/promises"
4+
import * as vscode from "vscode"
55

66
/**
77
* A class for tracking memory usage and logging resource lifecycles
@@ -32,7 +32,9 @@ export class MemoryLogger {
3232
}
3333

3434
this.logInterval = setInterval(() => {
35-
if (this.disposed) return
35+
if (this.disposed) {
36+
return
37+
}
3638
this.logMemoryUsage("PERIODIC")
3739
this.logResourceCounts()
3840
}, intervalMs)
@@ -159,7 +161,9 @@ export class MemoryLogger {
159161
* Write to log file
160162
*/
161163
private async writeToLogFile(message: string): Promise<void> {
162-
if (!this.logFile) return
164+
if (!this.logFile) {
165+
return
166+
}
163167

164168
try {
165169
const timestamp = new Date().toISOString()

src/remote.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ import { Commands } from "./commands"
1616
import { featureSetForVersion, FeatureSet } from "./featureSet"
1717
import { getHeaderCommand } from "./headers"
1818
import { Inbox } from "./inbox"
19+
import { getMemoryLogger } from "./memoryLogger"
1920
import { SSHConfig, SSHValues, mergeSSHConfigValues } from "./sshConfig"
2021
import { computeSSHProperties, sshSupportsSetEnv } from "./sshSupport"
2122
import { Storage } from "./storage"
2223
import { AuthorityPrefix, expandPath, parseRemoteAuthority } from "./util"
2324
import { WorkspaceMonitor } from "./workspaceMonitor"
24-
import { getMemoryLogger } from "./memoryLogger"
2525

2626
export interface RemoteDetails extends vscode.Disposable {
2727
url: string

src/workspacesProvider.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import {
1111
extractAgents,
1212
errToStr,
1313
} from "./api-helper"
14-
import { Storage } from "./storage"
1514
import { getMemoryLogger } from "./memoryLogger"
15+
import { Storage } from "./storage"
1616

1717
export enum WorkspaceQuery {
1818
Mine = "owner:me",
@@ -71,7 +71,7 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
7171

7272
logger.info(`WorkspaceProvider(${this.getWorkspacesQuery}): Starting workspace fetch`)
7373
this.fetching = true
74-
let fetchStart = Date.now()
74+
const fetchStart = Date.now()
7575

7676
// It is possible we called fetchAndRefresh() manually (through the button
7777
// for example), in which case we might still have a pending refresh that
@@ -348,7 +348,7 @@ function monitorMetadata(agentId: WorkspaceAgent["id"], restClient: Api): AgentW
348348
logger.error(`Metadata EventSource error for agent: ${agentId}`, error)
349349

350350
// If connection closes permanently, clean up resources
351-
if ((error as any).readyState === EventSource.CLOSED) {
351+
if (eventSource.readyState === EventSource.CLOSED) {
352352
logger.info(`Metadata EventSource connection closed for agent: ${agentId}`)
353353
if (!disposed) {
354354
watcher.dispose()

0 commit comments

Comments
 (0)