Recent update to the filebrowser moduel breaks subdomains

[evilhamsterman]

In the recent commit 22b2ad5 the command was changed to fix the fact that the filebrowser.db file didn't exist on first run so the filebrowser config set --baseurl command fails until the second time you run it.

However the way the command is interpreted if you use a subdomain and so therefore the baseurl is "" causes the command to fail because it thinks that there is no argument provided to the --baseurl option

$ cat /tmp/filebrowser.log
Error: flag needs an argument: --baseurl
Usage:
  filebrowser [flags]
  filebrowser [command]
...

Because of this it now fails to start at all when using a subdomain

[matifali]

Hi @dstoffel. I guess you should take a look.

@evilhamsterman thanks for the report amd sorry that the recent change broke it.

We probably need to have better integrated testing.

[dstoffel]

sorry for the breaking change, i did not notice the tests file was not checking this.
@evilhamsterman let me know if you need help for the fix

[evilhamsterman]

@dstoffel I think the issue can be resolved by just adding a = sign and quoting to ensure the --baseurl="${SERVER_BASE_URL}" is explicitly defined as an empty string if using a subdomain, which is valid. It just doesn't like no value being specified.

I created a PR as well that I thought might be a bit cleaner way of handling it long term, but both should work, which ever is easier to get merged and fix it

[lsalazarm99]

The fix isn't published yet, right? I'm still having this problem.

[matifali]

Yes, we need to push an update. I will do so as soon as we merge #426

[matifali]

Hi @lsalazarm99, this should be fixed in version 1.0.31. Can you test again? Thanks.