You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coder Connect spinner will spin indefinitely and never come up.
We've traced it to Downloader.cs which maintains a ConcurrentDictionary called _downloads, which tracks in-progress download tasks keyed off destination path. We don't ever clear tasks out of this dictionary when they complete, so a new download, for a different URL gets stuck in a loop looking up the task in the dictionary, waiting for it (which returns instantly because it's done), and then noticing it's for a different URL, and retrying in a loop.
The text was updated successfully, but these errors were encountered:
fixes#69
Fixes `Downloader` to remove the `DownloadTask` when it is done via a completion. This will allow changing Coder deployments, which use different URLs but whose files are downloaded to the same place.
Reproduction steps:
Coder Connect spinner will spin indefinitely and never come up.
We've traced it to
Downloader.cs
which maintains a ConcurrentDictionary called_downloads
, which tracks in-progress download tasks keyed off destination path. We don't ever clear tasks out of this dictionary when they complete, so a new download, for a different URL gets stuck in a loop looking up the task in the dictionary, waiting for it (which returns instantly because it's done), and then noticing it's for a different URL, and retrying in a loop.The text was updated successfully, but these errors were encountered: