Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Remove the message on password prompt or an option to change the message #5980

Closed
4 tasks done
niteshk9894 opened this issue Jan 19, 2023 · 3 comments
Closed
4 tasks done
Labels
duplicate enhancement Some improvement that isn't a feature

Comments

@niteshk9894
Copy link

niteshk9894 commented Jan 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

Web Browser: Chrome
Local OS: macOS
Remote OS: Ubuntu
Remote Architecture: amd64
code-server --version: 4.0.1

Steps to Reproduce

open code-server and set password

Expected

There should an option to change the below highlighted message or remove it. It would be helpful to add custom message.
And also telling user that your password is stored at $PASSWORD on login page doesn't help users.

image

Actual

shows password message.

Logs

No response

Screenshot/Video

image

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response

@niteshk9894 niteshk9894 added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jan 19, 2023
@jsjoeio jsjoeio removed the triage This issue needs to be triaged by a maintainer label Jan 19, 2023
@jsjoeio jsjoeio changed the title [Bug]: Remove the message on password prompt or an option to change the message [Feat]: Remove the message on password prompt or an option to change the message Jan 19, 2023
@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature and removed bug Something isn't working labels Jan 19, 2023
@jsjoeio jsjoeio added this to the Backlog Candidates milestone Jan 19, 2023
@niteshk9894
Copy link
Author

any update when and which release this will be added. It is a minor change i think.

Thanks in advance.

@code-asher
Copy link
Member

PRs are welcome but currently this is on the backlog so no plans on working on it at the moment.

I wonder if we should leverage the i18n files for this because then users could change any string they want since I think that would be much better than continuing to add CLI flags for all the text variations.

@code-asher
Copy link
Member

Merging this into #5857

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

3 participants