[Feat]: --app-name across the app

[tobycm]

What is your suggestion?

#5633 this but across the app and not just Login/Error page

Why do you want this feature?

Would be nice to customize "code-server" on the titlebar to something else of my choice

Are there any workarounds to get this functionality today?

I don't know

Are you interested in submitting a PR for this?

I'll try

[jsjoeio]

I think we'd need to decide if this is something we want to support. cc @code-asher

I can see both sides personally.

[code-asher]

Personally I think if someone is wanting to rebrand code-server they could repackage with an edited product.json (actually maybe we should use product.json for the login page too). And if there was effort to make this dynamically customizable I think it should go upstream rather than a patch in code-server.

[npenin]

This is apparently already covered in many places like

code-server/src/node/routes/vscode.ts

Line 51 in c995988

name: appName,

. Not sure why this is not working yet though.

[code-asher]

That particular change has not been released yet.

[code-asher]

This is released, but let me know if there are places we missed.

[TheZoker]

@code-asher
I think the default title if no file is open still does not use the app-name, right?

I started the application like this:

code-server --app-name "VS Code"

Edit:
And here as well

https://github.com/coder/code-server/blob/main/src/browser/pages/error.html#L14

[code-asher]

Oh yeah, looks like you are right. We should add a new template variable for the HTML files.