Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Delegate to upstream remote-cli script #5414

Open
code-asher opened this issue Aug 4, 2022 · 0 comments
Open

[Feat]: Delegate to upstream remote-cli script #5414

code-asher opened this issue Aug 4, 2022 · 0 comments
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@code-asher
Copy link
Member

code-asher commented Aug 4, 2022

What is your suggestion?

Right now we use the script in lib/vscode/bin/remote-cli inside the integrated terminal but we should use it from our own script as well because it provides more than our implementation.

Why do you want this feature?

So things we have not implemented like --wait work even outside code-server and so we can remove our incomplete implementation.

Are there any workarounds to get this functionality today?

Use an absolute path to run it. Or put it in your PATH but then you could not run the server since that script only allows interacting with existing instances of code-server.

Are you interested in submitting a PR for this?

Yeah, will probably take this on.

Implementation notes

Probably easiest to keep the existing logic but then instead of talking to the Code socket ourselves spawn the remote-cli script.

Edit: need to make sure it supports stdin as well, see #5693

@code-asher code-asher added the enhancement Some improvement that isn't a feature label Aug 4, 2022
@jsjoeio jsjoeio added this to the On Deck milestone Aug 4, 2022
@code-asher code-asher changed the title [Feat]: Use upstream remote-cli script in external terminals [Feat]: Delegate to upstream remote-cli script Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

2 participants