Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use hased-password in a different file #4510

Closed
anhdle14 opened this issue Nov 15, 2021 · 4 comments
Closed

Add support to use hased-password in a different file #4510

anhdle14 opened this issue Nov 15, 2021 · 4 comments
Labels
feature New user visible feature

Comments

@anhdle14
Copy link

Hoping code-server can use the same technique like jupyter server (reference). Basically:

  • New code-server password command to prompt for password and save it to ~/.config/code-server/password.json.
  • Remove hased-password: key from ~/.config/code-server/config.yaml.

This will help end users to commit the config.yaml file to dotfiles git repository without leaking credentials.

@anhdle14 anhdle14 added the feature New user visible feature label Nov 15, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 15, 2021

Remove hased-password: key from ~/.config/code-server/config.yaml.

This would be a breaking change.

This will help end users to commit the config.yaml file to dotfiles git repository without leaking credentials.

But I can see the value of this.

@jsjoeio jsjoeio added this to the Backlog Candidates milestone Nov 15, 2021
@ashvinnihalani
Copy link

ashvinnihalani commented Nov 17, 2021

If backwords compat is an issue couldn't you just have the hashed-password-file key in the config file that takes precedence over the hashed-password key. That way you don't break compat and can still have this feature.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 17, 2021

@ashvinnihalani I suppose that would solve that - fantastic suggestion ♥️

@stale
Copy link

stale bot commented May 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label May 16, 2022
@stale stale bot closed this as completed May 21, 2022
@code-asher code-asher removed the stale label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New user visible feature
Projects
None yet
Development

No branches or pull requests

4 participants