Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more solutions #2

Open
abhishalya opened this issue Jul 12, 2019 · 5 comments
Open

Add more solutions #2

abhishalya opened this issue Jul 12, 2019 · 5 comments
Labels
hacktoberfest hacktoberfest

Comments

@abhishalya
Copy link
Member

I've already added mine, add yours' too.

There is one small problem though, this repository checks for every .cpp file through CPPLintBear (based on https://github.com/cpplint/cpplint). So, the CI will fail for any error thrown by the bear.

You can either add your files and verify that the bear doesn't fail, or, you can add all such files to the ignore setting in .coafile. In the end, I just want a green build.

Ping @codemute/contributors

@bkhanale
Copy link
Member

I'm already quite busy with my GSoC project, also I haven't been updating my repository from a long long time. Also, linting jobs are quite troublesome since I don't think anyone lint their code during a contest.

But anyway, I will try to get these once I'm free, sorry for the delay :)

@abhishalya
Copy link
Member Author

Yeah, no worries.

@abhishalya abhishalya added the hacktoberfest hacktoberfest label Oct 4, 2019
@abhishalya
Copy link
Member Author

Ping @codemute/contributors could be a nice one for Hacktoberfest!

abhishalya added a commit that referenced this issue Oct 4, 2019
abhishalya added a commit that referenced this issue Oct 4, 2019
@abhishalya
Copy link
Member Author

I'll be doing lot more CP this and next month (until GCI starts), so more PRs to come up from my side.

abhishalya added a commit that referenced this issue Oct 4, 2019
@abhishalya
Copy link
Member Author

Btw, I've removed the cpp linting job and now there is no need to modify your existing code. Just create a PR as it is, we will get it merged quickly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants