-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: replace custom file path resolver with globby #770
Comments
Thank you for another good suggestion 😄 I agree, and would likewise be happy to review a PR or help whoever wants to get started on this. I may have time to get to this and #771, but not in the immediate future. |
Sounds good. And while I'm in here, would you mind if I submitted PRs to use other sorts of third-party libs, like using |
If there's a clear benefit to using the 3rd party libs in terms of improved functionality or reduced complexity or performance improvements or similar, and the libs are popular and maintained, then that's fine. |
For what it's worth, I also addressed this in https://github.com/NickHeiner/jscodemod. |
I see that the current file path resolver manually traverses directories, and hardcodes to exclude some directories, like
node_modules
.I suggest using a third-party solution like
globby
instead. This automatically gives functionality like more sophisticated patterns, or pattern exclusions. And it reduces the amount of code in this project.And, instead of hardcoding directories to ignore, I'd recommend reading the user's
gitignore
and just ignoring everything there.The text was updated successfully, but these errors were encountered: