Skip to content

Commit bc0a2d8

Browse files
committed
refactor: make QRSPI instructions principle-driven with sharp phase separation
Rewrote all phase instructions from verbose STEP-by-STEP checklists to concise principle statements. Each phase now has a single **Principle** line + goals + explicit 'Do not' constraints. - questions: 'Clarify intent before exploring solutions' — do not research/design/plan/code - research: 'Gather facts before forming opinions' — do not propose solutions/design/code - design: 'Align on WHAT and WHY before detailed HOW' — do not plan implementation/code - structure: 'Decompose into end-to-end testable units' — do not plan tasks/code - plan: 'Define detailed HOW per slice' — do not change design/code - implement: 'Execute plan one slice at a time' — adapt tactics, loop back only if fundamentally flawed - commit: 'Leave codebase cleaner than found' — do not add features File: 373 → 245 lines (-34%). All 7 states, 3 review gates, 19 transitions preserved.
1 parent bf00645 commit bc0a2d8

2 files changed

Lines changed: 90 additions & 209 deletions

File tree

.vibe/development-plan-feat-qrspi-infra-workflow.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,15 @@
4141
- [x] **Design Docs Updated on Loop-Back**: When `need_design_changes` loops back to design, the agent updates `$DESIGN_DOC` and `$ARCHITECTURE_DOC` if they exist, to reflect the revised direction
4242
- [x] **Delegation Principle Replaces Context Magic Number**: Removed "40% context window" magic number from plan and implement phases. Instead, implement phase now instructs delegating each vertical slice to a fresh agent session with focused context
4343
- [x] **Document Contradictions Trigger Design Loop-Back**: Plan phase now instructs that if `$REQUIREMENTS_DOC`, `$ARCHITECTURE_DOC`, or `$DESIGN_DOC` contradict what is needed for the increment, document the contradiction in the development plan and use `need_design_changes` to loop back to design
44+
- [x] **Verbosity Reduced — Principles Over Prescription**: After comparing with colleague's PR #283, instructions rewritten to rely on single **Principle** statements per phase (e.g., "Clarify intent before exploring solutions") rather than STEP-by-STEP prescriptive checklists. File went from 373 lines to 245 lines (-34%).
45+
- [x] **Phase Separation Sharpened**: Each phase now has a razor-sharp responsibility with explicit "Do not X" constraints:
46+
- questions: Do not research, design, plan, or write code
47+
- research: Do not propose solutions, make design decisions, or write code
48+
- design: Do not plan detailed implementation or write code
49+
- structure: Do not plan implementation tasks or write code
50+
- plan: Do not change the design direction or write code
51+
- implement: Adapt tactics within slices; loop back only if high-level approach is fundamentally flawed
52+
- commit: Do not add new features
4453

4554
## Notes
4655
*Additional context and observations*
@@ -139,7 +148,7 @@
139148
- [x] Updated `resources/state-machine-schema.json` with missing fields (`allowed_file_patterns`, `review_perspectives`, `domain`)
140149
- [x] Updated development plan with all key decisions and insights
141150
- [x] Committed and pushed changes on `feat/qrspi-infra-workflow` branch
142-
- [x] Created pull request via gh CLI
151+
- [x] Created pull request via gh CLI: https://github.com/codemcp/workflows/pull/282
143152

144153

145154

0 commit comments

Comments
 (0)