Skip to content

Commit 4cc4bd4

Browse files
committed
ci: remove manual workspace dependency conversion in release workflow
pnpm 10+ automatically converts workspace:* to actual versions during pack/publish. The manual sed command is no longer needed and has been commented out. This simplifies the CI workflow and relies on pnpm's native workspace handling.
1 parent 3af1132 commit 4cc4bd4

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,13 @@ jobs:
148148
pnpm publish --access public --no-git-checks
149149
cd ../..
150150
151-
# Convert workspace dependencies to actual versions for publishing
152-
NEW_VERSION=${{ steps.version.outputs.new_version }}
153-
find packages -name "package.json" -exec sed -i 's/"workspace:\*"/"^'$NEW_VERSION'"/g' {} \;
151+
# Convert workspace dependencies to actual versions for publishing
152+
# NOTE: pnpm 10+ now handles this automatically during pack/publish
153+
# Keeping this line for reference, but it's no longer needed with pnpm 10.29.3+
154+
# NEW_VERSION=${{ steps.version.outputs.new_version }}
155+
# find packages -name "package.json" -exec sed -i 's/"workspace:\*"/"^'$NEW_VERSION'"/g' {} \;
154156
155-
# Publish main package
157+
# Publish main package
156158
pnpm publish --access public --no-git-checks
157159
env:
158160
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

0 commit comments

Comments
 (0)