fix: reset is_windows() mock state in CIUnitTestCase::tearDown() (#10554)

Author: gr8man

system/Test/CIUnitTestCase.php

@@ -273,6 +273,8 @@ protected function tearDown(): void
 
         // Check for other trait methods
         $this->callTraitMethods('tearDown');
+
+        $this->resetIsWindowsMock();
     }
 
     /**
@@ -318,6 +320,14 @@ protected function resetServices(bool $initAutoloader = true)
         Services::reset($initAutoloader);
     }
 
+    /**
+     * Resets the mocked is_windows() function back to default state.
+     */
+    protected function resetIsWindowsMock(): void
+    {
+        is_windows(null);
+    }
+
     /**
      * Injects the mock Cache driver to prevent filesystem collisions.
      *

tests/system/CommonFunctionsTest.php

@@ -863,7 +863,7 @@ public function testIsWindowsUsingMock(): void
         $this->assertFalse(is_windows());
         $this->assertNotTrue(is_windows());
 
-        is_windows();
+        is_windows(null);
         $this->assertSame(str_contains(php_uname(), 'Windows'), is_windows());
         $this->assertSame(defined('PHP_WINDOWS_VERSION_MAJOR'), is_windows());
     }

tests/system/Test/TestCaseTest.php

@@ -93,4 +93,29 @@ public function testCloseEnoughStringBadLength(): void
         $result = $this->assertCloseEnoughString('apples & oranges', 'apples');
         $this->assertFalse($result, 'Different string lengths should have returned false');
     }
+
+    public function testTearDownResetsIsWindowsMock(): void
+    {
+        $testCase = new class ('test') extends CIUnitTestCase {
+            protected $tearDownMethods = ['customTearDown'];
+
+            protected function customTearDown(): void
+            {
+            }
+
+            public function triggerTearDown(): void
+            {
+                $this->tearDown();
+            }
+        };
+
+        $default = DIRECTORY_SEPARATOR === '\\';
+
+        is_windows(! $default);
+        $this->assertSame(! $default, is_windows());
+
+        $testCase->triggerTearDown();
+
+        $this->assertSame($default, is_windows());
+    }
 }