fix: correct cache directory permissions mode to 0755 in FileVarExportHandler

Author: gr8man

system/Cache/FactoriesCache/FileVarExportHandler.php

@@ -23,7 +23,7 @@ public function save(string $key, mixed $val): void
 
         // Two processes may try to create the directory at the same time.
         // is_dir() confirms it exists, so suppressing the warning is safe.
-        if (! is_dir($this->path) && ! @mkdir($this->path, 0777, true) && ! is_dir($this->path)) {
+        if (! is_dir($this->path) && ! @mkdir($this->path, 0755, true) && ! is_dir($this->path)) {
             log_message('error', 'FactoriesCache: cannot create cache directory: ' . $this->path);
 
             return;

tests/system/Cache/FactoriesCacheFileVarExportHandlerTest.php

@@ -15,6 +15,7 @@
 
 use CodeIgniter\Cache\FactoriesCache\FileVarExportHandler;
 use PHPUnit\Framework\Attributes\Group;
+use ReflectionProperty;
 
 /**
  * @internal
@@ -27,4 +28,30 @@ protected function createFactoriesCache(): void
         $this->handler = new FileVarExportHandler();
         $this->cache   = new FactoriesCache($this->handler);
     }
+
+    public function testSaveCreatesDirectoryWithCorrectPermissions(): void
+    {
+        $dir = WRITEPATH . 'cache_test_dir_' . uniqid('', true);
+
+        try {
+            $handler = new FileVarExportHandler();
+            $ref     = new ReflectionProperty(FileVarExportHandler::class, 'path');
+            $ref->setValue($handler, $dir);
+
+            $handler->save('test_key', ['data']);
+
+            $this->assertDirectoryExists($dir);
+
+            if (! is_windows()) {
+                $perms    = fileperms($dir) & 0777;
+                $expected = 0755 & ~umask();
+                $this->assertSame($expected, $perms);
+            }
+        } finally {
+            if (is_dir($dir)) {
+                array_map('unlink', glob("{$dir}/*") ?: []);
+                rmdir($dir);
+            }
+        }
+    }
 }