CR-9668 app proxy on timeout (#279)

* add git integration + user PAT even when wait for runtime sync is timed out
* replaced network-tester job with pod
* display right message at the end of the installation
* change to 8m timeout, and exit-code to 0

Author: ATGardner

CHANGELOG.md

@@ -1,3 +1,4 @@
 # Changelog:
 
-* updated to cap-app-proxy:0.0.27 (fix [CR-9420](https://codefresh-io.atlassian.net/browse/CR-9420))
+* Create git integration and user PAT even when installation check times out
+* Replace pre-install network check Job with a simple Pod

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.255
+VERSION=v0.0.256
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/config.go

@@ -92,7 +92,7 @@ func RunConfigCreateContext(ctx context.Context, context, apiKey, url string) er
 	if err := cfConfig.CreateContext(ctx, context, apiKey, url); err != nil {
 		return err
 	}
-	log.G().Infof("New context created: '%s'", context)
+	log.G().Infof("New context created: \"%s\"", context)
 	return RunConfigUseContext(ctx, context)
 }
 

cmd/commands/git-source.go

@@ -230,7 +230,7 @@ func RunGitSourceCreate(ctx context.Context, opts *GitSourceCreateOptions) error
 		return fmt.Errorf("failed to create git-source application. Err: %w", err)
 	}
 
-	log.G(ctx).Infof("Successfully created git-source: '%s'", opts.GsName)
+	log.G(ctx).Infof("Successfully created git-source: \"%s\"", opts.GsName)
 
 	return nil
 }
@@ -656,7 +656,7 @@ func RunGitSourceEdit(ctx context.Context, opts *GitSourceEditOptions) error {
 	}
 
 	log.G(ctx).Info("Pushing updated GitSource to the installation repo")
-	if err := apu.PushWithMessage(ctx, repo, fmt.Sprintf("Persisted an updated git-source '%s'", opts.GsName)); err != nil {
+	if err := apu.PushWithMessage(ctx, repo, fmt.Sprintf("Persisted an updated git-source \"%s\"", opts.GsName)); err != nil {
 		return fmt.Errorf("failed to persist the updated git-source: %s. Err: %w", opts.GsName, err)
 	}
 

cmd/commands/integrations.go

@@ -440,7 +440,7 @@ func verifyOutputFormat(format string, allowedFormats ...string) error {
 func parseGitProvider(provider string) (model.GitProviders, error) {
 	p, ok := gitProvidersByName[provider]
 	if !ok {
-		return model.GitProviders(""), fmt.Errorf("provider '%s' is not a valid provider name", provider)
+		return model.GitProviders(""), fmt.Errorf("provider \"%s\" is not a valid provider name", provider)
 	}
 	return p, nil
 }