Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] - Add loading animation to modals #637

Open
andycwilliams opened this issue May 20, 2024 · 0 comments · May be fixed by #654
Open

[Discovery] - Add loading animation to modals #637

andycwilliams opened this issue May 20, 2024 · 0 comments · May be fixed by #654
Assignees
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features

Comments

@andycwilliams
Copy link
Member

andycwilliams commented May 20, 2024

Note: This issue is marked for discovery. It is open for discussion and not necessarily decided upon.

Describe the Current Behavior/Feature:

When the user uploads a file from the Upload Document modal, there is no indication about the progress. There is a notification upon completion or failure, but nothing until then.

Rationale:

Adding this animation would provide real-time feedback to the user so they know if it's working, and whether the upload even began or not. For small files, this isn't a big problem. But for larger ones it would be good to give more information.

Example of how it currently appears once a file is selected and the Upload button pressed:
CurrentUploadDocumentProcess2

The only visible change is the Upload button becoming greyed out.

Proposed Changes:

  • Add a simple loading animation to modals that (namely the Upload Document modal).
  • Try implementing LoadingAnimation.jsx rather than create a new, separate function or component.
  • Style it based off of the proposed design from the Figma board:
AddUploadingAnimation
@andycwilliams andycwilliams added enhancement Enhancement of existing features discovery Open discussion and exploration of topic on hand labels May 20, 2024
@russfraze russfraze self-assigned this May 22, 2024
@russfraze russfraze linked a pull request Jun 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants