Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Unwanted swiper-pagination-bullet. #263

Open
Abhijay007 opened this issue May 12, 2021 · 6 comments
Open

Unwanted swiper-pagination-bullet. #263

Abhijay007 opened this issue May 12, 2021 · 6 comments
Assignees

Comments

@Abhijay007
Copy link

There is an unwanted swiper-pagination-bullet on the home page.

screenshot

Screenshot (20)

@carltos0411
Copy link

carltos0411 commented May 12, 2021

@vasudevsinghal I want to work on this issue

@KeenWarrior
Copy link
Contributor

GO ahead @carltos0411

@priyansh11786
Copy link

I am just a beginner in open source and I am looking forward to work on this issue, Can someone help me through it. Thanks in advance!

@Abhijay007
Copy link
Author

Abhijay007 commented Jun 29, 2021

@priyansh11786 sorry for the late response you can follow these steps for Opening a PR in future.

first follow these steps to setup project locally in your machine:

1. Fork this repository.

2. Clone your forked copy of the project.

git clone --depth 1 https://github.com/<your_user_name>/codeforcause.org.git

3. Navigate to the project directory 📁 .

cd codeforcause.org

4. Add a reference(remote) to the original repository.

git remote add upstream https://github.com/codeforcauseorg/codeforcause.org.git

5. Check the remotes for this repository.

git remote -v

6. Always take a pull from the upstream repository to your master branch to keep it at par with the main project(updated repository).

git pull upstream master

7. Create a new branch.

git checkout -b <your_branch_name>

8. Perform your desired changes to the code base.

9. Track your changes:heavy_check_mark: .

git add .

10. Commit your changes .

git commit -m "Relevant message"

11. Push the committed changes in your feature branch to your remote repo.

git push -u origin <your_branch_name>

12. To create a pull request, click on `compare and pull request. Please ensure you compare your feature branch to the desired branch of the repo you are supposed to make a PR to.

YOU can read more about additional guidelines for beginners and the good first issue in the project readme.

once you can run the project locally, you can proceed further to find a bug or add a feature.

Let me tell you how I fix this bug:

  1. Firstly I stepped the project locally into my machine then I use inspect element of chrome browser (Ctrl + shift+ I to open it) to find from where this bug is genreted, (you can also use inspect to find possible class name and Ids associated with the code that you want to change).

inspect_bug

  1. if you are able to find anything related search in your Code editor to find the possible path for code. for example, in my case I searched for"subscribe" as it the closest button there:

screenshot for better understanding

searc_related

  1. once you are able to find the associated path try to find the cause of the bug in my case it is a unwanted prop passed in the Swiper component :

find the bug cause

  1. once you are done with the code changes Cross check it by running it on your local browser to find that whether the changes are made or not :

cross_check

once you are done with all this follow the above steps or steps given in readme to Open a PR.

I already opened a PR for this issue you can see changes here #298 you can also review it if you want :)

@sugatobagchi
Copy link

sugatobagchi commented Jul 21, 2021

Hello @Abhijay007

It's been a long time & I guess Priyansh is not working on this issue.

Can I start working on this issue? I am getting started with open-source. Thank you!

@KeenWarrior
Copy link
Contributor

Sure. Go ahead @sugatobagchi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants