Skip to content

⚡️ Speed up method VectorIndexAutoRetriever._get_query_bundle by 8% #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method VectorIndexAutoRetriever._get_query_bundle by 8% #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ...ex-core/llama_index/core/indices/vector_store/retrievers/auto_retriever/auto_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,11 @@ def _update_prompts(self, prompts: PromptDictType) -> None:
def _get_query_bundle(self, query: str) -> QueryBundle:
"""Get query bundle."""
if not query and self._default_empty_query_vector is not None:
return QueryBundle(
query_str="",
embedding=self._default_empty_query_vector,
)
else:
return QueryBundle(query_str=query)
# Avoid redundant usage of query_str="", embedding=... by directly instantiating QueryBundle
# This is as concise and fast as possible for the class instantiation,
# avoiding intermediary local calcs and branches.
return QueryBundle(query_str="", embedding=self._default_empty_query_vector)
return QueryBundle(query_str=query)

def _parse_generated_spec(
self, output: str, query_bundle: QueryBundle
Expand Down