Skip to content

⚡️ Speed up function get_child_nodes by 52% #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_child_nodes by 52% #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions llama-index-core/llama_index/core/node_parser/relational/hierarchical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,19 @@ def get_root_nodes(nodes: List[BaseNode]) -> List[BaseNode]:

def get_child_nodes(nodes: List[BaseNode], all_nodes: List[BaseNode]) -> List[BaseNode]:
"""Get child nodes of nodes from given all_nodes."""
children_ids = []
children_ids = set()
for node in nodes:
if NodeRelationship.CHILD not in node.relationships:
continue

children_ids.extend(
[r.node_id for r in node.relationships[NodeRelationship.CHILD]]
children_ids.update(
r.node_id for r in node.relationships[NodeRelationship.CHILD]
)

child_nodes = []
for candidate_node in all_nodes:
if candidate_node.node_id not in children_ids:
continue
child_nodes.append(candidate_node)
if not children_ids:
return []

return child_nodes
return [candidate_node for candidate_node in all_nodes if candidate_node.node_id in children_ids]


def get_deeper_nodes(nodes: List[BaseNode], depth: int = 1) -> List[BaseNode]:
Expand Down