You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browse_and_select_directory uses an unbounded while True. Invalid inputs (e.g., bad custom paths) could trap the user in the loop; consider retry limits or a clear exit option.
defbrowse_and_select_directory(start_dir: Path, message: str, title: str) ->Path|None:
"""Interactive directory browser with tab-completion-like functionality."""current_dir=start_dirwhileTrue:
# Get all subdirectories in current directorytry:
subdirs= []
foritemincurrent_dir.iterdir():
ifitem.is_dir() andnotitem.name.startswith('.'):
subdirs.append(item.name)
subdirs.sort()
exceptPermissionError:
console.print(f"❌ Permission denied accessing {current_dir}")
returnNone# Build choices listchoices= []
# Add parent directory option if not at start_dirifcurrent_dir!=start_dirandcurrent_dir.parent!=current_dir:
choices.append(("📁 .. (parent directory)", ".."))
# Add current directory selection optionchoices.append(("✅ Select this directory", "SELECT"))
# Add subdirectoriesforsubdirinsubdirs:
choices.append((f"📂 {subdir}/", subdir))
# Add option to type custom pathchoices.append(("⌨️ Type custom path", "CUSTOM"))
choices.append(("❌ Cancel", "CANCEL"))
# Show current directory in panelbrowse_panel=Panel(
Text(f"📍 Current directory: {current_dir}\n\n{message}", style="cyan"),
title=title,
border_style="bright_blue",
)
console.print(browse_panel)
console.print()
# Prompt for selectionquestions= [
inquirer.List(
"selection",
message="Navigate or select directory:",
choices=choices,
carousel=True,
)
]
answers=inquirer.prompt(questions, theme=CodeflashTheme())
ifnotanswers:
returnNoneselection=answers["selection"]
ifselection=="SELECT":
returncurrent_direlifselection=="CANCEL":
returnNoneelifselection=="..":
current_dir=current_dir.parentelifselection=="CUSTOM":
# Allow custom path inputcustom_panel=Panel(
Text("Enter a directory path (relative to current directory or absolute):", style="yellow"),
title="🔧 Custom Path",
border_style="bright_yellow",
)
console.print(custom_panel)
console.print()
custom_path=click.prompt("Directory path", type=str).strip()
ifcustom_path:
try:
ifPath(custom_path).is_absolute():
new_dir=Path(custom_path)
else:
new_dir=current_dir/custom_pathnew_dir=new_dir.resolve()
ifnew_dir.exists() andnew_dir.is_dir():
current_dir=new_direlse:
console.print(f"❌ Directory does not exist: {new_dir}")
click.pause()
exceptExceptionase:
console.print(f"❌ Invalid path: {e}")
click.pause()
else:
# Navigate to subdirectorytry:
new_dir=current_dir/selectionifnew_dir.exists() andnew_dir.is_dir():
current_dir=new_direlse:
console.print(f"❌ Directory not accessible: {new_dir}")
click.pause()
exceptExceptionase:
console.print(f"❌ Error accessing directory: {e}")
click.pause()
Broaden the exception handling to include other filesystem errors like OSError and show the error message. This prevents uncaught exceptions if iterdir fails for reasons other than permissions.
try:
subdirs = []
for item in current_dir.iterdir():
if item.is_dir() and not item.name.startswith('.'):
subdirs.append(item.name)
subdirs.sort()
-except PermissionError:- console.print(f"❌ Permission denied accessing {current_dir}")+except (PermissionError, OSError) as e:+ console.print(f"❌ Error accessing directory {current_dir}: {e}")
return None
Suggestion importance[1-10]: 6
__
Why: Expanding to catch OSError prevents uncaught filesystem errors during directory iteration and surfaces the actual error message.
Low
Prevent KeyError on selection
Guard against a missing "selection" key in the answers dict to avoid a potential KeyError. Use dict.get and explicitly handle the None case before proceeding.
answers = inquirer.prompt(questions, theme=CodeflashTheme())
if not answers:
return None
--selection = answers["selection"]+selection = answers.get("selection")+if selection is None:+ return None+
Suggestion importance[1-10]: 5
__
Why: Using answers.get("selection") guards against a missing key and avoids a potential KeyError, improving robustness.
Low
General
Use explicit Choice objects
Wrap each choice in an explicit inquirer.Choice to ensure the display name and value map correctly and avoid ambiguous tuple handling. This makes the list of choices more robust and clear for the prompt engine.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user already have a CF configuration:
Giving option to select nested directory on test file:
PR Type
Enhancement
Description
Add interactive directory browser functionality
Implement display_current_config for existing settings
Update reconfiguration prompt UX in init flow
Use browser for tests directory selection
Changes diagram
Changes walkthrough 📝
cmd_init.py
Add directory browser and config displaycodeflash/cli_cmds/cmd_init.py