From 502b328ba104d79550301343e9b9ac0fb4dfd143 Mon Sep 17 00:00:00 2001 From: "sentry[bot]" <39604003+sentry[bot]@users.noreply.github.com> Date: Tue, 23 Jun 2026 20:22:05 +0000 Subject: [PATCH] fix: Remove unused $isTeamPlan variable from PullPageData query --- .../PullBundleAnalysis/PullBundleAnalysis.tsx | 2 -- .../PullRequestPage/PullCoverage/PullCoverage.tsx | 9 +-------- src/pages/PullRequestPage/PullRequestPage.tsx | 4 ---- .../PullRequestPage/queries/PullPageDataQueryOpts.tsx | 11 +++-------- 4 files changed, 4 insertions(+), 22 deletions(-) diff --git a/src/pages/PullRequestPage/PullBundleAnalysis/PullBundleAnalysis.tsx b/src/pages/PullRequestPage/PullBundleAnalysis/PullBundleAnalysis.tsx index 829df835f2..122852f698 100644 --- a/src/pages/PullRequestPage/PullBundleAnalysis/PullBundleAnalysis.tsx +++ b/src/pages/PullRequestPage/PullBundleAnalysis/PullBundleAnalysis.tsx @@ -88,14 +88,12 @@ const BundleContent: React.FC = ({ const PullBundleAnalysis: React.FC = () => { const { provider, owner, repo, pullId } = useParams() - // we can set team plan true here because we don't care about the fields it will skip - tho we should really stop doing this and just return null on the API if they're on a team plan so we can save on requests made const { data } = useSuspenseQueryV5( PullPageDataQueryOpts({ provider, owner, repo, pullId, - isTeamPlan: true, }) ) diff --git a/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx b/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx index f44145c57e..d8b5ebd6ec 100644 --- a/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx +++ b/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx @@ -5,8 +5,7 @@ import { Redirect, Switch, useParams } from 'react-router-dom' import { SentryRoute } from 'sentry' import SilentNetworkErrorWrapper from 'layouts/shared/SilentNetworkErrorWrapper' -import { useRepoOverview, useRepoRateLimitStatus } from 'services/repo' -import { useIsTeamPlan } from 'services/useIsTeamPlan' +import { useRepoRateLimitStatus } from 'services/repo' import ComparisonErrorBanner from 'shared/ComparisonErrorBanner' import GitHubRateLimitExceededBanner from 'shared/GlobalBanners/GitHubRateLimitExceeded/GitHubRateLimitExceededBanner' import { ComparisonReturnType, ReportUploadType } from 'shared/utils/comparison' @@ -41,8 +40,6 @@ interface URLParams { function PullCoverageContent() { const { owner, repo, pullId, provider } = useParams() - const { data: overview } = useRepoOverview({ provider, owner, repo }) - const { data: isTeamPlan } = useIsTeamPlan({ provider, owner }) const { data } = useSuspenseQueryV5( PullPageDataQueryOpts({ @@ -50,7 +47,6 @@ function PullCoverageContent() { owner, repo, pullId, - isTeamPlan: (isTeamPlan && overview?.private) ?? false, }) ) @@ -129,8 +125,6 @@ function PullCoverageContent() { function PullCoverage() { const { owner, repo, pullId, provider } = useParams() - const { data: overview } = useRepoOverview({ provider, owner, repo }) - const { data: isTeamPlan } = useIsTeamPlan({ provider, owner }) const { data: rateLimit } = useRepoRateLimitStatus({ provider, owner, repo }) const { data } = useSuspenseQueryV5( @@ -139,7 +133,6 @@ function PullCoverage() { owner, repo, pullId, - isTeamPlan: (isTeamPlan && overview?.private) ?? false, }) ) diff --git a/src/pages/PullRequestPage/PullRequestPage.tsx b/src/pages/PullRequestPage/PullRequestPage.tsx index 1dc5cfcad3..7d9963b559 100644 --- a/src/pages/PullRequestPage/PullRequestPage.tsx +++ b/src/pages/PullRequestPage/PullRequestPage.tsx @@ -6,7 +6,6 @@ import { useLocation, useParams } from 'react-router-dom' import NotFound from 'pages/NotFound' import { useCrumbs } from 'pages/RepoPage/context' import { useRepoOverview } from 'services/repo' -import { useIsTeamPlan } from 'services/useIsTeamPlan' import Icon from 'ui/Icon' import Spinner from 'ui/Spinner' import SummaryDropdown from 'ui/SummaryDropdown' @@ -89,8 +88,6 @@ function PullRequestPage() { const location = useLocation() const { provider, owner, repo, pullId } = useParams() const { data: overview } = useRepoOverview({ provider, owner, repo }) - const { data: isTeamPlan } = useIsTeamPlan({ provider, owner }) - usePRPageBreadCrumbs({ owner, repo, @@ -104,7 +101,6 @@ function PullRequestPage() { owner, repo, pullId, - isTeamPlan: (isTeamPlan && overview?.private) ?? false, }) ) diff --git a/src/pages/PullRequestPage/queries/PullPageDataQueryOpts.tsx b/src/pages/PullRequestPage/queries/PullPageDataQueryOpts.tsx index 7bc4b07ac3..7f5f893a80 100644 --- a/src/pages/PullRequestPage/queries/PullPageDataQueryOpts.tsx +++ b/src/pages/PullRequestPage/queries/PullPageDataQueryOpts.tsx @@ -105,7 +105,6 @@ query PullPageData( $owner: String! $repo: String! $pullId: Int! - $isTeamPlan: Boolean! ) { owner(username: $owner) { repository(name: $repo) { @@ -136,10 +135,10 @@ query PullPageData( __typename ... on Comparison { impactedFilesCount - indirectChangedFilesCount @skip(if: $isTeamPlan) + indirectChangedFilesCount directChangedFilesCount - flagComparisonsCount @skip(if: $isTeamPlan) - componentComparisonsCount @skip(if: $isTeamPlan) + flagComparisonsCount + componentComparisonsCount } ... on FirstPullRequest { message @@ -181,7 +180,6 @@ interface PullPageDataQueryArgs { owner: string repo: string pullId: string - isTeamPlan?: boolean } export const PullPageDataQueryOpts = ({ @@ -189,7 +187,6 @@ export const PullPageDataQueryOpts = ({ owner, repo, pullId, - isTeamPlan = false, }: PullPageDataQueryArgs) => queryOptionsV5({ queryKey: [ @@ -198,7 +195,6 @@ export const PullPageDataQueryOpts = ({ owner, repo, pullId, - isTeamPlan, query, ], queryFn: ({ signal }) => @@ -211,7 +207,6 @@ export const PullPageDataQueryOpts = ({ owner, repo, pullId: parseInt(pullId, 10), - isTeamPlan, }, }).then((res) => { const callingFn = 'PullPageDataQueryOpts'