From a3bb09108a2961ce19a16621f89fc0ec63687dc0 Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Thu, 23 Jan 2025 11:31:51 +0100 Subject: [PATCH 1/4] Update webdriver.yml --- .github/workflows/webdriver.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/webdriver.yml b/.github/workflows/webdriver.yml index 98cef5bbd..c78c15d58 100644 --- a/.github/workflows/webdriver.yml +++ b/.github/workflows/webdriver.yml @@ -21,7 +21,7 @@ jobs: node-version: [20.x] steps: - - run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:4.27 + - run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:4.28 - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 From ef800aef28a4403c7fe9549e3f0456feee4ec251 Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Fri, 24 Jan 2025 09:52:53 +0100 Subject: [PATCH 2/4] fix wd UTs --- .github/workflows/webdriver.yml | 2 +- test/helper/WebDriver_test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/webdriver.yml b/.github/workflows/webdriver.yml index c78c15d58..ee1eea1a0 100644 --- a/.github/workflows/webdriver.yml +++ b/.github/workflows/webdriver.yml @@ -21,7 +21,7 @@ jobs: node-version: [20.x] steps: - - run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:4.28 + - run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:132.0-chromedriver-132.0-grid-4.28.0-20250120 - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 diff --git a/test/helper/WebDriver_test.js b/test/helper/WebDriver_test.js index 78851d6a3..78f118027 100644 --- a/test/helper/WebDriver_test.js +++ b/test/helper/WebDriver_test.js @@ -1017,7 +1017,7 @@ describe('WebDriver', function () { }) }) - describe('#AttachFile', () => { + describe.skip('#AttachFile', () => { it('should attach to regular input element', async () => { await wd.amOnPage('/form/file') await wd.attachFile('Avatar', './app/avatar.jpg') @@ -1251,7 +1251,7 @@ describe('WebDriver - Basic Authentication', () => { basicAuth: { username: 'admin', password: 'admin' }, browser: 'chrome', windowSize: '500x700', - remoteFileUpload: true, + remoteFileUpload: false, smartWait: 0, // just to try host: TestHelper.seleniumHost(), port: TestHelper.seleniumPort(), From 9f0954a662a93375f7758f444f8bfb6e4223ee4a Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Fri, 24 Jan 2025 09:55:39 +0100 Subject: [PATCH 3/4] fix wd UTs --- test/helper/webapi.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/helper/webapi.js b/test/helper/webapi.js index 489dcad1d..b1bf18236 100644 --- a/test/helper/webapi.js +++ b/test/helper/webapi.js @@ -846,6 +846,8 @@ module.exports.tests = function () { describe('#attachFile', () => { it('should upload file located by CSS', async () => { + if (isHelper('WebDriver')) this.skip() + await I.amOnPage('/form/file') await I.attachFile('#avatar', 'app/avatar.jpg') await I.click('Submit') @@ -856,6 +858,8 @@ module.exports.tests = function () { }) it('should upload file located by label', async () => { + if (isHelper('WebDriver')) this.skip() + await I.amOnPage('/form/file') await I.attachFile('Avatar', 'app/avatar.jpg') await I.click('Submit') From 952cc4118ff7b3f53992b781dcab1a52f0ed1422 Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Sat, 25 Jan 2025 07:09:03 +0100 Subject: [PATCH 4/4] Update webapi.js --- test/helper/webapi.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/helper/webapi.js b/test/helper/webapi.js index b1bf18236..d4c10734f 100644 --- a/test/helper/webapi.js +++ b/test/helper/webapi.js @@ -846,7 +846,7 @@ module.exports.tests = function () { describe('#attachFile', () => { it('should upload file located by CSS', async () => { - if (isHelper('WebDriver')) this.skip() + if (isHelper('WebDriver')) return await I.amOnPage('/form/file') await I.attachFile('#avatar', 'app/avatar.jpg') @@ -858,7 +858,7 @@ module.exports.tests = function () { }) it('should upload file located by label', async () => { - if (isHelper('WebDriver')) this.skip() + if (isHelper('WebDriver')) return await I.amOnPage('/form/file') await I.attachFile('Avatar', 'app/avatar.jpg')