-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix CI scripts #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI scripts #596
Conversation
@codebude Any update here? |
@codebude Think we could merge this in? |
Hi @Shane32 , since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR. Would you prefer me to merge it before the archival, or should I close it instead? Thanks again for your effort and contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates CI workflows to address deprecation of windows-2019
runner images and fix path issues caused by changes in the runner environment.
- Updates all workflow jobs from
windows-2019
towindows-latest
- Replaces hardcoded paths with
${{ github.workspace }}
variable for cross-platform compatibility - Simplifies .NET SDK setup in formatting workflow to use only .NET 8.0 and switches to Ubuntu runner
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/wf-verify-formatting.yml | Switches to Ubuntu runner, simplifies .NET SDK versions, and adds Windows targeting environment variable |
.github/workflows/wf-build-test.yml | Updates runner version and replaces hardcoded paths with workspace variable |
.github/workflows/wf-build-release.yml | Updates runner version and replaces hardcoded paths with workspace variable |
.github/workflows/wf-build-release-ci.yml | Updates runner version and replaces hardcoded paths with workspace variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Tests fixed to account for changes in PR #602 |
There are no remaining changes here, since #592 was already merged |
Updates CI scripts as follows:
D:\a\qrcoder\qrcoder
to${{ github.workspace }}
(due to it actually beingC:\a\qrcoder\qrcoder
now)