Skip to content

Conversation

Shane32
Copy link
Owner

@Shane32 Shane32 commented Jun 17, 2025

Updates CI scripts as follows:

@Shane32
Copy link
Owner Author

Shane32 commented Jun 17, 2025

@gfoidl @codebude This PR fixes CI runs

@Shane32
Copy link
Owner Author

Shane32 commented Aug 17, 2025

@codebude Any update here?

@Shane32
Copy link
Owner Author

Shane32 commented Sep 1, 2025

@codebude Think we could merge this in?

@codebude
Copy link
Collaborator

Hi @Shane32 ,

since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR.

Would you prefer me to merge it before the archival, or should I close it instead?
Please let me know what you think – I want to handle your contribution in the way that feels most appropriate to you.

Thanks again for your effort and contribution!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates CI workflows to address deprecation of windows-2019 runner images and fix path issues caused by changes in the runner environment.

  • Updates all workflow jobs from windows-2019 to windows-latest
  • Replaces hardcoded paths with ${{ github.workspace }} variable for cross-platform compatibility
  • Simplifies .NET SDK setup in formatting workflow to use only .NET 8.0 and switches to Ubuntu runner

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/wf-verify-formatting.yml Switches to Ubuntu runner, simplifies .NET SDK versions, and adds Windows targeting environment variable
.github/workflows/wf-build-test.yml Updates runner version and replaces hardcoded paths with workspace variable
.github/workflows/wf-build-release.yml Updates runner version and replaces hardcoded paths with workspace variable
.github/workflows/wf-build-release-ci.yml Updates runner version and replaces hardcoded paths with workspace variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Shane32
Copy link
Owner Author

Shane32 commented Sep 30, 2025

Tests fixed to account for changes in PR #602

@Shane32
Copy link
Owner Author

Shane32 commented Sep 30, 2025

There are no remaining changes here, since #592 was already merged

@Shane32 Shane32 closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants