ActiveRecord belongs_to setting: optional: true where needed

[olleolleolle]

While upgrading Rails, at one time, we didn't change to all the new default behaviors, but we auto-enabled the old behavior, postponing some work. This Issue is about such a chore.

Step 1: disable this "automatic optional" setting in config/application.rb

    # TODO: sort this out properly at 
    # See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#active-record-belongs-to-required-by-default-option
    config.active_record.belongs_to_required_by_default = false

Step 2: in each model's belongs_to associations, decide whether that is an optional relationship or not. Where it is optional, add the keyword argument optional: true.

Step 3: pass all tests, and you are done!

[davidmillen50]

taking a look

[davidmillen50]

@olleolleolle it looks like config.active_record.belongs_to_required_by_default = false is already enforced in the config so not sure a change is needed there. Also, I went through each model and it looks like the belongs_to associations are pretty much all required for the records they associate with based on what associations I think these models need. However, one of these associations are enforced on the database level as the belongs_to fields for all models are nullable. How do we want to proceed?

[olleolleolle]

@davidmillen50 To clarify, we want to go to true. We are lazy with the false setting, and want to be clearer with the true one.

Non-lazy here is EXPLICIT rather than implicit.

[davidmillen50]

see #2259

[olleolleolle]

Yes!

♥️ 💛 💚 💙 💜

[olleolleolle]

Fixed in #2259