Skip to content

Conversation

@bfolkens
Copy link
Contributor

@bfolkens bfolkens commented Nov 6, 2025

Closes #31

On apple-darwin, libraries are compiled as *.dylib, though Rustler expects a *.so extname. This patch updates the library name symlinked in preConfigure to match what Rustler expects when loading the file at runtime.

@bfolkens bfolkens force-pushed the bf/31_patch_lib_extname_on_apple_darwin branch from 8956623 to 29073d2 Compare November 6, 2025 14:18
@bfolkens bfolkens marked this pull request as ready for review November 6, 2025 20:32
@camelpunch
Copy link
Contributor

Is there a dependency we can add to the fixture project that fails without this change?

@bfolkens
Copy link
Contributor Author

Explorer was what was failing for me, but at runtime. That package is already included in the test suite so it seems we may need to include some sort of runtime test in the suite (if not already there). I'll play around with it a bit to see if I can come up with a failure case...

@bfolkens bfolkens force-pushed the bf/31_patch_lib_extname_on_apple_darwin branch from 29073d2 to 016a9a2 Compare November 30, 2025 18:17
@bfolkens
Copy link
Contributor Author

@camelpunch ok this should be ready for another look. I added a run-time case which runs "mix test" and that attemps to run Explorer (which fails until the patch is applied).

Copy link
Contributor

@camelpunch camelpunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how to get your force-push rerun in GitHub Actions, but it looks to me like it's running a SHA that isn't on your current branch. Or I'm just confused. Either way, would you mind looking at the comments?

Happy to help with the Linux part if you don't have access to a Linux machine.

EDIT I was just confused, and was looking at the SHA after a merge into main. Weirdly, when I (or GitHub) merge your branch, the check gets past the error I posted. I'd still like to preserve the ability to build arbitrary mix deps from nix, though.

@bfolkens bfolkens force-pushed the bf/31_patch_lib_extname_on_apple_darwin branch from 016a9a2 to d603d09 Compare December 6, 2025 22:13
@bfolkens
Copy link
Contributor Author

bfolkens commented Dec 6, 2025

Hi @camelpunch - thanks for the suggestion. I made the edit, let me know if that's what you had in mind. I also rebased the branch to main out of concern about the failing build above - I noticed it was a bit behind now.

@camelpunch camelpunch merged commit 3fbc89a into code-supply:main Dec 7, 2025
4 checks passed
@camelpunch
Copy link
Contributor

Thanks ❤️

@bfolkens bfolkens deleted the bf/31_patch_lib_extname_on_apple_darwin branch December 7, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform/arch not being set consistently

2 participants