Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #180 Gives Compile Error in UE4 #183

Closed
tsender opened this issue Oct 30, 2022 · 4 comments
Closed

PR #180 Gives Compile Error in UE4 #183

tsender opened this issue Oct 30, 2022 · 4 comments

Comments

@tsender
Copy link
Contributor

tsender commented Oct 30, 2022

See my comment at the bottom of the PR page: #180

Essentially, the added BP feature uses type 'double', but only UE5 supports type 'double' in blueprints, UE4 does not. Attempting to place the appropriate code in a preprocessor directive to check if the engine version is 4 or 5 does not work, as UE does not support this with UFUNCTIONS (darn).

The only options are to remove the void OnFloat64Message(const double& Data) function added in RI/Topic.h and its corresponding cpp code. OR to create a separate branch for UE5.

This is not my repo, so I'm not sure how you want to proceed @Sanic (but my preference is to remove the code, but that's because I much prefer cpp over blueprints).

@kabel-knrd
Copy link

Hi!
I currently have the same problem with the UE4.27.
@tsender Have you found a decent workaround that works for you? So have you found a way, where the plugin compiles?

Thanks!

@Sanic
Copy link
Contributor

Sanic commented Nov 4, 2022

Hi @tsender
Thanks for reporting!
I gave it a thought i think that the main platform of the master branch should be UE4.
So i would be happy to receive a PR for the partial removing of #180 with the related code you've described here.

@tsender
Copy link
Contributor Author

tsender commented Nov 8, 2022

Hopefully there aren't too many more issues with differences b/w UE4 and UE5 that can't be easily accounted for, like in preprocessor directives, but you might want to add a note to the README saying the master branch is maintained for UE4, and if the need arises, then perhaps you can make a UE5 branch. Just a thought.

@tsender tsender closed this as completed Nov 8, 2022
@Sanic
Copy link
Contributor

Sanic commented Nov 10, 2022

@tsender Good point! I've added a remark to the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants