Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores as raw characters are escaped #14

Open
Hamms opened this issue Apr 17, 2018 · 0 comments
Open

Underscores as raw characters are escaped #14

Hamms opened this issue Apr 17, 2018 · 0 comments
Labels
bug Something isn't working curriculum builder This relates to concerns specific to CurriculumBuilder content

Comments

@Hamms
Copy link
Collaborator

Hamms commented Apr 17, 2018

A source string such as "Top ____ Tips for Conducting a Great Interview" in CB will get output to just that same string, but when going through the redaction process the underscores will be escaped to prevent them from being parsed as control characters, resulting in redacted string "Top \_\_\_\_ Tips for Conducting a Great Interview".

Although both of these result in the same HTML output, the inconsistency is worrying. At the very least, it would be nice to prove out that this change cannot have any significant impact on the output, and at best it should be sanitized.

@Hamms Hamms added bug Something isn't working curriculum builder This relates to concerns specific to CurriculumBuilder content labels Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working curriculum builder This relates to concerns specific to CurriculumBuilder content
Projects
None yet
Development

No branches or pull requests

1 participant