feat(build): use native typescript compiler #64178
Open
+124
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for esbuild/tsup is to use the microsoft api extractor, to generate typescript declarations. However, this appears to result in some memory leaks which ends up causing the build time of declaration files to take very long. This then causes watchers on the webpack side to receive updated javascript but without its associated declarations. Instead, noting that the [official documentation](https://tsup.egoist.dev/#generate-declaration-file) says to use `tsc`, the tsup `onSuccess` hook is then used to generate the typescript declarations in the same manner as before, except using `tsc`. The net result is that the declarations are generated significantly faster, about 2 seconds vs the previous 30-60 seconds.
stephenliang
force-pushed
the
stephen/improve-tsup-devex
branch
from
6690ff7 to
8074fc3
Compare
🖼️ Visual Comparison Report✅ No eyes differences detected! |
snickell
approved these changes
Feb 27, 2025
| @@ -24,6 +24,7 @@ | |||
| "lint": "turbo lint", | |||
| "lint:fix": "turbo lint:fix", | |||
| "release:dryrun": "turbo release:dryrun", | |||
| "start": "yarn dev", | |||
There was a problem hiding this comment.
Appreciate the operational consistency detail here
| "lint": "eslint .", | ||
| "lint:fix": "eslint --fix .", | ||
| "prepack": "clean-package", | ||
| "postpack": "clean-package restore", | ||
| "prettier": "prettier --check .", | ||
| "prettier:fix": "prettier --write .", | ||
| "release": "release-it --preRelease=alpha", | ||
| "start": "yarn dev", |
There was a problem hiding this comment.
Suggested change
| "start": "yarn dev", | |
| "start": "cd .. && yarn start --filter @code-dot-org/component-library", |
Just an idea, I'm guessing tsup --watch here doesn't end up rolling the build up far enough for apps to see?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for esbuild/tsup is to use the microsoft api extractor, to generate typescript declarations. However, this appears to result in some memory leaks which ends up causing the build time of declaration files to take very long. This then causes watchers on the webpack side to receive updated javascript but without its associated declarations.
Instead, noting that the official documentation says to use
tsc, the tsuponSuccesshook is then used to generate the typescript declarations in the same manner as before, except usingtsc. The net result is that the declarations are generated significantly faster, about 2 seconds vs the previous 30-60 seconds.