Sorting of donation goals by amount doesn't work correctly

[joshsmith]

Problem

When the donation goal hasDirtyAttributes it gets sorted to the top of the list for some reason. I tried a number of things to fix this but no dice. In particular, I thought the transform would affect it. This seemed to make no difference.

Subtasks

• Identify the issue
• Write a regression test
• Fix it

[begedin]

I didn't actually realise we started sorting them.

Ignoring this issue with sorting, what would happen if everything worked ok and we, while editing a goal that's somewhere in the middle of the list, we set the amount to 0? Would the whole form jump down to the bottom?

Maybe we should not be editing in place and just have subroutes for these things?

Alternatively, maybe we ought to just not sort via a computed and instead, upon saving changes to a goal, sort the whole list manually? Instead of rendering project.donationGoals, we could set a manually sorted sortedDonationGoals at the route/controller level and just pass that into the template.

[joshsmith]

@begedin after saving, no, the form would not jump to the bottom. But the new goal would. That feels nature when I'm working with it, but the buggy behavior obviously does not.

I tried doing a manually sorted sortedDonationGoals. This also suffered the same issue.