included with project and task

Author: snewcomer

lib/code_corps_web/views/project_jsonapi_view.ex

@@ -0,0 +1,43 @@
+defmodule CodeCorpsWeb.ProjectJsonapiView do
+  @moduledoc false
+  alias CodeCorps.StripeService.Validators.ProjectCanEnableDonations
+  alias CodeCorps.Presenters.ImagePresenter
+
+  use JSONAPI.View, type: "project"
+  use CodeCorpsWeb, :view
+
+  def fields, do: [
+  	:approval_requested,
+    :approved,
+    :can_activate_donations,
+    :cloudinary_public_id,
+    :description,
+    :donations_active,
+    :icon_thumb_url,
+    :icon_large_url,
+    :inserted_at,
+    :long_description_body,
+    :long_description_markdown,
+    :should_link_externally,
+    :slug,
+    :title,
+    :total_monthly_donated,
+    :updated_at,
+    :website
+  ]
+
+  def can_activate_donations(project, _conn) do
+    case ProjectCanEnableDonations.validate(project) do
+      {:ok, _} -> true
+      {:error, _} -> false
+    end
+  end
+
+  def donations_active(project, _conn) do
+    Enum.any?(project.donation_goals) && project.stripe_connect_plan != nil
+  end
+
+  def icon_large_url(project, _conn), do: ImagePresenter.large(project)
+
+  def icon_thumb_url(project, _conn), do: ImagePresenter.thumbnail(project)
+end

lib/code_corps_web/views/project_view.ex

@@ -36,8 +36,6 @@ defmodule CodeCorpsWeb.ProjectView do
   has_many :project_skills, serializer: CodeCorpsWeb.ProjectSkillView, identifiers: :always
   has_many :project_users, serializer: CodeCorpsWeb.ProjectUserView, identifiers: :always
   has_many :skills, serializer: CodeCorpsWeb.SkillView, identifiers: :always
-  has_many :tasks, serializer: CodeCorpsWeb.TaskView, identifiers: :always
-  has_many :task_lists, serializer: CodeCorpsWeb.TaskListView, identifiers: :always
 
   def can_activate_donations(project, _conn) do
     case ProjectCanEnableDonations.validate(project) do

lib/code_corps_web/views/task_jsonapi_view.ex

@@ -0,0 +1,43 @@
+defmodule CodeCorpsWeb.TaskJsonapiView do
+  @moduledoc false
+  use CodeCorpsWeb, :view
+  use JSONAPI.View, type: "task"
+
+  def fields, do: [
+    :archived, :body, :created_at, :created_from, :has_github_pull_request,
+    :inserted_at, :markdown, :modified_at, :modified_from, :number, :order,
+    :overall_status, :status, :title, :updated_at
+  ]
+
+  # def relationships do
+  #   [github_issue]
+  # end
+
+  # has_one :github_issue, type: "github-issue", field: :github_issue_id
+  # has_one :github_pull_request, serializer: CodeCorpsWeb.GithubPullRequestView, identifiers: :always
+  # has_one :github_repo, type: "github-repo", field: :github_repo_id
+  # has_one :project, type: "project", field: :project_id
+  # has_one :task_list, type: "task-list", field: :task_list_id
+  # has_one :user, type: "user", field: :user_id
+  # has_one :user_task, serializer: CodeCorpsWeb.UserTaskView, identifiers: :always
+
+  # has_many :comments, serializer: CodeCorpsWeb.CommentView, identifiers: :always
+  # has_many :task_skills, serializer: CodeCorpsWeb.TaskSkillView, identifiers: :always
+
+  def has_github_pull_request(%{
+    github_pull_request: %CodeCorps.GithubPullRequest{}
+  }), do: true
+  def has_github_pull_request(%{github_pull_request: nil}), do: false
+
+  def overall_status(%{
+    github_pull_request: %CodeCorps.GithubPullRequest{merged: merged, state: state}
+  }, _conn) do
+    case merged do
+      true -> "merged"
+      false -> state
+    end
+  end
+  def overall_status(%{github_pull_request: nil, status: status}, _conn) do
+    status
+  end
+end

lib/code_corps_web/views/task_list_view.ex

@@ -3,11 +3,11 @@ defmodule CodeCorpsWeb.TaskListView do
   use CodeCorpsWeb, :view
   use JSONAPI.View, type: "task-list"
 
-  alias CodeCorpsWeb.{ProjectView, TaskView}
+  alias CodeCorpsWeb.{ProjectJsonapiView, TaskJsonapiView}
 
   def fields, do: [:done, :inbox, :name, :order, :pull_requests, :inserted_at, :updated_at]
 
   def relationships do
-    [project: ProjectView, tasks: TaskView]
+    [project: {ProjectJsonapiView, :include}, tasks: {TaskJsonapiView, :include}]
   end
 end

test/lib/code_corps_web/views/project_view_test.exs

@@ -12,8 +12,6 @@ defmodule CodeCorpsWeb.ProjectViewTest do
     project_skill = insert(:project_skill, project: project, skill: skill)
     project_user = insert(:project_user, project: project)
     stripe_connect_plan = insert(:stripe_connect_plan, project: project)
-    task_list = insert(:task_list, project: project)
-    task = insert(:task, task_list: task_list, project: project)
 
     host = Application.get_env(:code_corps, :asset_host)
 
@@ -102,22 +100,6 @@ defmodule CodeCorpsWeb.ProjectViewTest do
               "id" => stripe_connect_plan.id |> Integer.to_string,
               "type" => "stripe-connect-plan"
             }
-          },
-          "task-lists" => %{
-            "data" => [
-              %{
-                "id" => task_list.id |> Integer.to_string,
-                "type" => "task-list"
-              }
-            ]
-          },
-          "tasks" => %{
-            "data" => [
-              %{
-                "id" => task.id |> Integer.to_string,
-                "type" => "task"
-              }
-            ]
           }
         },
         "type" => "project",

test/lib/code_corps_web/views/task_list_view_test.exs

@@ -1,7 +1,6 @@
 defmodule CodeCorpsWeb.TaskListViewTest do
   use CodeCorpsWeb.ViewCase
 
-  @tag :wip
   test "renders all attributes and relationships properly" do
     project = insert(:project)
     task_list = insert(:task_list, order: 1000, project: project)
@@ -38,7 +37,48 @@ defmodule CodeCorpsWeb.TaskListViewTest do
         },
         type: "task-list",
       },
-      :included => [],
+      :included => [
+        %{
+          attributes: %{
+            "approval-requested" => false, 
+            "approved" => project.approved,
+            "cloudinary-public-id" => nil, 
+            "description" => project.description, 
+            "inserted-at" => project.inserted_at,
+            "long-description-body" => project.long_description_body, 
+            "long-description-markdown" => project.long_description_markdown,
+            "should-link-externally" => false, 
+            "slug" => project.slug,
+            "title" => project.title,
+            "total-monthly-donated" => 0, 
+            "updated-at" => project.updated_at,
+            "website" => project.website
+          }, 
+          id: project.id |> Integer.to_string,
+          relationships: %{}, 
+          type: "project"
+          }, 
+          %{
+            attributes: %{
+              "archived" => false, 
+              "body" => nil, 
+              "created-at" => task.created_at,
+              "created-from" => task.created_from,
+              "inserted-at" => task.inserted_at,
+              "markdown" => "A test task", 
+              "modified-at" => task.modified_at,
+              "modified-from" => task.modified_from,
+              "number" => task.number,
+              "order" => task.order,
+              "status" => task.status,
+              "title" => task.title,
+              "updated-at" => task.updated_at
+            }, 
+            id: task.id |> Integer.to_string,
+            relationships: %{}, 
+            type: "task"
+          }
+      ],
       :links => %{}
     }