Ensure Project.create_changeset casts a proper ProjectUser association for owner

Author: begedin

Diff for: test/models/project_test.exs

@@ -1,7 +1,9 @@
 defmodule CodeCorps.ProjectTest do
   use CodeCorps.ModelCase
 
-  alias CodeCorps.Project
+  import CodeCorps.Project
+
+  alias CodeCorps.{Project, ProjectUser, Repo}
 
   describe "changeset" do
     @valid_attrs %{title: "A title"}
@@ -43,42 +45,46 @@ defmodule CodeCorps.ProjectTest do
     end
   end
 
-  describe "create_changeset" do
-    @valid_attrs %{title: "A title", organization_id: 1, owner_id: 1}
-    @invalid_attrs %{}
-
+  describe "create_changeset/3" do
     test "with valid attributes" do
-      changeset = Project.create_changeset(%Project{}, @valid_attrs)
+      organization = insert(:organization)
+      attrs = %{title: "A title", organization_id: organization.id}
+      changeset = create_changeset(%Project{}, attrs)
       assert changeset.valid?
     end
 
     test "with invalid attributes" do
-      changeset = Project.create_changeset(%Project{}, @invalid_attrs)
+      changeset = create_changeset(%Project{}, %{})
       refute changeset.valid?
     end
 
-    test "accepts setting of organization_id" do
-      changeset = Project.create_changeset(%Project{}, %{organization_id: 1})
-      assert {:ok, 1} == changeset |> fetch_change(:organization_id)
+    test "casts :organization_id and ensures organization exists" do
+      attrs = %{title: "A title", organization_id: -1}
+      changeset = create_changeset(%Project{}, attrs)
+
+      assert {:error, failed_insert_changeset} = changeset |> Repo.insert()
+
+      refute failed_insert_changeset.valid?
+      assert error_message(failed_insert_changeset, :organization) == "does not exist"
     end
 
-    test "associates the ordered default task lists to the project" do
+    test "casts and inserts proper associated records" do
       organization = insert(:organization)
-      user = insert(:user)
-      changeset = Project.create_changeset(
-        %Project{},
-        %{organization_id: organization.id, title: "Title", owner_id: user.id}
-      )
+      attrs = %{title: "A title", organization_id: organization.id}
+      changeset = Project.create_changeset(%Project{}, attrs)
 
       {_, project} = Repo.insert(changeset)
 
       task_list_orders = for task_list <- project.task_lists, do: task_list.order
 
       assert Enum.all?(task_list_orders), "some of the orders are not set (nil)"
       assert task_list_orders == Enum.sort(task_list_orders), "task lists order does not correspond to their position"
-    end
 
-    test "also inserts an owner role project_user record"
+      project_user = Repo.one(ProjectUser)
+      assert project_user.project_id == project.id
+      assert project_user.user_id == organization.owner_id
+      assert project_user.role == "owner"
+    end
   end
 
   describe "update_changeset" do

Diff for: web/controllers/project_controller.ex

@@ -26,7 +26,7 @@ defmodule CodeCorps.ProjectController do
     |> approved_filter(true)
   end
 
-  def handle_create(_conn, attributes) do
+  def handle_create(conn, attributes) do
     %Project{} |> Project.create_changeset(attributes)
   end
 

Diff for: web/models/project.ex

@@ -64,7 +64,9 @@ defmodule CodeCorps.Project do
     |> changeset(params)
     |> cast(params, [:organization_id])
     |> put_assoc(:task_lists, TaskList.default_task_lists())
+    |> put_member_assoc()
     |> generate_icon_color(:default_color)
+    |> assoc_constraint(:organization)
   end
 
   @doc """
@@ -82,4 +84,19 @@ defmodule CodeCorps.Project do
     struct
     |> cast(params, [:total_monthly_donated])
   end
+
+  @spec put_member_assoc(Changeset.t) :: Changeset.t
+  defp put_member_assoc(changeset) do
+    case changeset |> get_change(:organization_id) |> get_organization do
+      nil ->
+        changeset
+      organization ->
+        changeset
+        |> put_assoc(:project_users, [%{user_id: organization.owner_id, role: "owner"}])
+    end
+  end
+
+  @spec get_organization(integer | nil) :: CodeCorps.Organization.t :: nil
+  defp get_organization(nil), do: nil
+  defp get_organization(id), do: CodeCorps.Repo.get(CodeCorps.Organization, id)
 end