Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: surface missized DELSIZED tombstones via PossibleAPIMisuse #4234

Open
jbowens opened this issue Jan 7, 2025 · 0 comments
Open

db: surface missized DELSIZED tombstones via PossibleAPIMisuse #4234

jbowens opened this issue Jan 7, 2025 · 0 comments
Labels
A-storage C-cleanup T-storage

Comments

@jbowens
Copy link
Collaborator

jbowens commented Jan 7, 2025 •
edited by cockroach-jira-scripts
Loading

The new PossibleAPIMisuse event surfaces indications of possible misuse of the Pebble API. We should add an event kind for DELSIZED tombstones that did not accurately record the size of the value they deleted. Today these instances are surfaced via (pebble.Metrics).Keys.MissizedTombstonesCount and we assert on them only when a Cockroach Engine is created with the storage.ForTesting option.

Jira issue: PEBBLE-319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-storage C-cleanup T-storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbowens